chore: update XML app theme to Material 3 - #527
Merged
Conversation
The app theme parented `android:Theme.Material.Light.NoActionBar`, the platform Material 1 theme, while the rest of the project is Compose Material 3. Switch it to `Theme.Material3.DayNight.NoActionBar` so the pre-Compose window frame matches the app, and follows the system dark setting like `CuriosityTheme` already does. `Theme.Material3.*` is a library resource, so this requires `com.google.android.material:material` in the app module. It is used for the XML theme only; the library modules stay Compose-only.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The app's XML theme parented
android:Theme.Material.Light.NoActionBar— the platform Material 1 theme — while the rest of the project is Compose Material 3. This switches it toTheme.Material3.DayNight.NoActionBar, so the pre-Compose window frame matches the app and follows the system dark setting the same wayCuriosityThemealready does viaisSystemInDarkTheme().Theme.Material3.*is a library resource (the Android platform ships no M3 theme), so this addscom.google.android.material:material1.14.0 to the app module. It is used for the XML theme only — no Kotlin or Compose code changed, and the library modules (curiosity,navigation,settings) stay Compose-only.UI
No Compose UI changes. The only visible difference is the window background drawn before Compose takes over, which now respects dark mode instead of always being light.
Review checklist
make all