Skip to content

chore: v0.12.0 pre-release review and cleanup - #105

Merged
derrickmehaffy merged 7 commits into
releases/0.12.0from
chore/0.12.0-review-cleanup
Mar 15, 2026
Merged

chore: v0.12.0 pre-release review and cleanup#105
derrickmehaffy merged 7 commits into
releases/0.12.0from
chore/0.12.0-review-cleanup

Conversation

@derrickmehaffy

Copy link
Copy Markdown
Contributor

Description

Pre-release review and cleanup of the releases/0.12.0 branch before tagging. Covers code quality fixes, Sentry error routing, documentation accuracy, changelog completions, CurseForge description overhaul, and version bump.

Code Quality (2 commits)

  • Remove 3 unused imports (MessageUtil x2, UUID)
  • Make SentryIntegration.initialized volatile for thread safety
  • Replace System.err.println in EventBus with ErrorHandler.report()
  • Convert ~80 Logger-only catch blocks across 38 files to ErrorHandler.report() (logs to console and sends to Sentry)
  • Fix duplicate Logger.warn + ErrorHandler.report patterns in worldmap files

Documentation (2 commits)

  • Add missing CHANGELOG entries: SimpleClaims/FactionsX importers, BetterMap compatibility, i18n, ocean claim fix
  • Update README feature tables: importers (4), config migration (v1–v8), admin GUI pages (Implemented), localization (Implemented), GUI page count (70+), zone flags (51), HyperProtect hooks (28)
  • Update all 12 docs/ version headers to 0.12.0
  • Add SimpleClaims + FactionsX sections to data-import.md
  • Add V6→V7 and V7→V8 to migration table
  • Add AdminConfigPage, AdminBackupsPage, AdminUpdatesPage, ScalingTiersModalPage to gui.md
  • Add ZoneMobClearManager to managers.md
  • Add BetterMap compatibility to integrations.md
  • Add import subcommands to commands.md admin tree

CurseForge Description (2 commits)

  • New "What's New in v0.12.0" section
  • Add missing Core Features: faction economy with upkeep, localization (10 languages)
  • Convert integrations from nested lists to tables
  • Fix zone flag count (50 → 51), GUI page count (76 → 70+), HyperProtect hook count (27 → 28)
  • Fix Integration flags category (was listing removed flags, now matches ZoneFlags.INTEGRATION_FLAGS)
  • Remove Sentry from public description (developer-only), remove command blocking (not implemented)
  • Update data import references, JitPack version

Version Bump

  • build.gradle version 0.11.10.12.0

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • Documentation update
  • Refactoring (no functional changes)

Related Issues

Relates to the 7 PRs merged into releases/0.12.0:

Testing

  • Tested on local development server
  • Verified no regressions in existing functionality
  • ./gradlew :HyperFactions:shadowJar — BUILD SUCCESSFUL
  • Test failures (54) are pre-existing on releases/0.12.0, not introduced by this PR
  • Grep verified: no remaining System.err.println or e.printStackTrace() in runtime code

Checklist

  • My code follows the project's coding style
  • I have performed a self-review of my own code
  • I have updated the documentation (if applicable)
  • My changes generate no new warnings or errors

Accuracy Verification

All CurseForge description claims verified against source code:

Claim Code Status
51 zone flags ZoneFlags.ALL_FLAGS (51 entries) Verified
70+ GUI pages 67 page classes in gui/*/page/ Verified
28 HyperProtect hooks 28 SLOT_ constants Verified
11 OrbisGuard-Mixins hooks 11 register methods Verified
49 PAPI / 47 WiFlow placeholders Expansion classes Verified
46 commands FactionCommand.java Verified
11 config files ConfigManager.java Verified
5 leaderboard sorts SortMode enum Verified
5 world map refresh modes RefreshMode enum Verified
4 data importers importer package Verified

- Remove unused MessageUtil import from AdminSubCommand and AdminEconomyHandler
- Remove unused UUID import from TreasuryCommandHandler
- Make SentryIntegration.initialized volatile for thread safety
- Replace System.err.println in EventBus with ErrorHandler.report
Convert Logger-only catch blocks across the codebase to use
ErrorHandler.report(), which logs to console AND sends to Sentry.
Covers platform, managers, integrations, storage, worldmap, GUI,
migrations, territory, and update packages.

Informational warnings (not in catch blocks) are intentionally
left as Logger.warn calls.
- Add missing changelog entries: SimpleClaims/FactionsX importers,
  BetterMap compatibility, i18n localization, ocean claim visibility fix
- Update README feature tables: importers, config version, admin GUI
  status, localization, GUI page count
- Update all 12 docs/ version headers to 0.12.0
- Add SimpleClaims and FactionsX sections to data-import.md
- Add V6->V7 and V7->V8 to migration table
- Add admin GUI pages to gui.md (ConfigPage, BackupsPage, UpdatesPage)
- Add ZoneMobClearManager to managers.md
- Add BetterMap compatibility to integrations.md
- Add import subcommands to commands.md admin tree
- Replace What's New section with v0.12.0 features (i18n, admin GUI
  pages, SimpleClaims/FactionsX importers, BetterMap, ocean fix)
- Update data import references to include all 4 importers
- Update GUI page count from 65+ to 70+
- Update JitPack version to v0.12.0
- Fix zone flag count: 50 -> 51 (verified against ZoneFlags.ALL_FLAGS)
- Fix Integration flags category: was listing removed flags (command
  blocking, fluid spread, map visibility), now lists actual flags
  (gravestone access, show on map, essentials homes/warps/kits)
- Fix GUI page count: 76 -> 70+ (67 actual page classes)
- Add missing Core Features: faction economy with upkeep system,
  localization (10 languages)
- Remove Sentry from public-facing description (dev-only feature)
- Convert integrations section from nested lists to tables for
  easier maintenance as the list grows
- Also fix zone flag count in README (50 -> 51)
- Fix HyperProtect-Mixin hook count: 27 -> 28 (verified SLOT_ constants)
- Remove "Command blocking in zones" from README (not yet implemented)
@derrickmehaffy
derrickmehaffy merged commit 91140b2 into releases/0.12.0 Mar 15, 2026
@derrickmehaffy
derrickmehaffy deleted the chore/0.12.0-review-cleanup branch March 15, 2026 20:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant