Add ts CLI ad-template config diagnostics and browser audit

[prk-Jr]

Summary

• Adds operator tooling to verify server-side ad-template ([creative_opportunities]) configuration: static path/slot diagnostics via ts config ad-templates …, and browser-backed live verification via ts audit … (local Chrome/Chromium over CDP).
• Adds ts audit ad-templates generate <url> to bootstrap [creative_opportunities] from a live site. One run crawls the publisher's sections (sitemap via robots.txt, else navigation links), samples a landing page and an article per section, reconciles each slot across the pages it appeared on, and writes the result into an existing trusted-server.toml in place, preserving every other section and comment.
• Where the evidence proves it, the run infers a {network_id}/{section} ad-unit template plus the section_root/section_segment policy it depends on, instead of pinning each slot to the one literal path it happened to be scraped from. A wrong template makes a publisher bid against inventory that does not exist, so inference refuses rather than guesses — see the table below.
• Everything the run writes is validated before it replaces the file: the candidate goes through Settings::from_toml, the same load path the runtime uses at startup, on the --dry-run path too. An unloadable trusted-server.toml is a full-site outage once pushed, not a degraded ad stack.
• Lets publishers catch slot/config drift before deploy — match a path to configured slots, assert expected slots in CI, explain runtime ad-stack gating, and confirm configured slots actually render (DOM/GPT/APS evidence) on live pages.
• Keeps the CLI host-only: browser deps (chromiumoxide) are excluded from the wasm32-wasip1 build, and the runtime ad-stack gate is shared with publisher.rs so the CLI cannot drift from server behavior.

Stacks on the EdgeZero CLI base (server-side-ad-templates-impl). After merging the base back in, the diff against it is feature-only.

Behavior change: bare ts audit <url> remains a hidden alias for ts audit generate <url>; the base branch's draft-artifact generation moved to the explicit ts audit generate <url>.

Deploy ordering — read before pushing generated config. A config carrying section_root or section_segment is not rollback-safe. CreativeOpportunitiesConfig is deny_unknown_fields, so a binary predating ad-unit templating (cee1e20e) rejects the entire Settings load — not just the ad-template section — and every route serves an error. Deploy the template-aware binary first, then push, and do not roll that binary back while the config is live. A run that did not template writes neither key and leaves the config exactly as rollback-safe as it was. The command prints this warning itself.

closes #701

Changes

Area	Change
trusted-server-core/src/creative_opportunities.rs	[creative_opportunities] config types, match_slots, shared evaluate_ad_stack_gate; compile_page_pattern as the single glob definition; derive_section made public so tooling checks inference against the runtime's own derivation rather than a second implementation
trusted-server-core/src/publisher.rs	Route should_run_server_side_ad_stack through the shared gate (behavior-preserving)
trusted-server-cli/src/commands/config/ad_templates.rs	ts config ad-templates {lint,match,check,explain} static diagnostics
trusted-server-cli/src/app_config.rs	Shared effective app-config loader for the config + audit commands
trusted-server-cli/src/ad_templates/{expected,compare,output}.rs	Pure expected-slot projection, DOM/GPT/APS evidence comparison, stable JSON model, terminal-safe text escaping
trusted-server-cli/src/commands/audit/{mod,page,collector,browser,ad_templates}.rs, commands/audit/ad_template_collector.js	ts audit page + ts audit ad-templates verify: chromiumoxide collector, read-only GPT/APS/DOM init script, verifier orchestration, cross-origin refusal
trusted-server-cli/src/commands/audit/generate/crawl_plan.rs	New. Turns links and sitemap entries into a bounded page set — one landing page and one article per section, ranked by nav/sitemap corroboration, capped by section and page budgets, same-origin enforced on both sources
trusted-server-cli/src/commands/audit/generate/evidence.rs	New. Cross-page slot evidence: formats unioned, divergent unit paths retained, network ids required to agree, and detection of one placement fragmented across per-render div ids
trusted-server-cli/src/commands/audit/generate/unit_template.rs	New. {network_id}/{section} inference with positional network binding, a single-varying-segment rule, the witness rule, and replay through the runtime's own renderer
trusted-server-cli/src/commands/audit/generate/page_patterns.rs	New. Expands observed paths into per-section glob pairs (/news and /news/*) without extrapolating past a witnessed section
trusted-server-cli/src/commands/audit/generate/validate.rs	New. Write-side gate: the candidate config must load through Settings::from_toml before it replaces the file; a pre-existing failure downgrades to a warning so an already-broken config can still be updated
trusted-server-cli/src/commands/audit/generate/{mod,gpt_slots}.rs	Crawl orchestration, challenge-rate refusal, per-page diagnostics; slot reconstruction from live GPT plus normalization of ephemeral div-id noise (React _R_/_r_ ids, -container, hex UUIDs)
trusted-server-cli/src/commands/audit/generate/{browser_collector,collector,analyzer}.rs	Batch collection on one reused browser, hydrated-DOM link extraction, in-page sitemap fetch, device profiles, request pacing, consent answering, proxy support
trusted-server-cli/src/run.rs, src/lib.rs	Command wiring and parser tests for the audit namespace
trusted-server-cli/Cargo.toml	Host-only edgezero-core + serde_json deps (cfg-gated off wasm, like the existing browser deps)
docs/guide/cli.md	ts audit ad-templates generate documented: crawl behavior, refusal table, consent platforms, proxy auditing, and the deploy-ordering contract
docs/superpowers/{specs,plans}/2026-06-26-server-side-ad-template-cli*	Design spec and implementation plan

Test plan

Per CLAUDE.md, a bare cargo test/cargo clippy --workspace fails at the workspace root — the repo has multiple wasm runtimes with runtime-specific SDKs, so the target-matched aliases are the real gate.

• cargo fmt --all -- --check
• cargo clippy-fastly && cargo clippy-axum && cargo clippy-cloudflare && cargo clippy-cloudflare-wasm && cargo clippy-spin-native && cargo clippy-spin-wasm
• cargo clippy -p trusted-server-cli --target <host-triple> --all-targets --all-features -- -D warnings
• cargo test-fastly && cargo test-axum && cargo test-cloudflare && cargo test-spin
• cargo test --manifest-path crates/trusted-server-integration-tests/Cargo.toml --test parity (13 passed)
• Host CLI tests: cargo test -p trusted-server-cli --target <host-triple> — 347 passed
• JS tests: cd crates/trusted-server-js/lib && npx vitest run (829 passed)
• JS format: cd crates/trusted-server-js/lib && npm run format
• Docs format: cd docs && npm run format
• WASM build: cargo build --package trusted-server-adapter-fastly --release --target wasm32-wasip1 (plus cargo build -p trusted-server-cli --target wasm32-wasip1 — browser deps stay out of wasm)
• Chrome-gated browser fixtures (./scripts/test-cli.sh) for evidence collection and scroll-phase attribution
• Manual: full crawl against a live publisher through ts dev proxy — template and section policy inferred, per-render div-id fragments refused, generated config loads through Settings::from_toml

Notable fixture-based coverage, all offline: crawl planning (cross-origin rejection on links and sitemap entries, utility/asset filtering, query/fragment collapsing, budget truncation), evidence reconciliation (format union, network-id conflict, fragment detection with a co-occurrence false-positive guard), and one test per template-inference refusal case.

How to use

Static ts config ad-templates … commands only read local effective config (no browser). Browser-backed ts audit … commands launch a local Chrome/Chromium.

Configure slots

In your (gitignored) trusted-server.toml — fictional values shown:

[creative_opportunities]
gam_network_id = "123"
section_root = "homepage"     # required when a template uses {section}

[[creative_opportunities.slot]]
id = "atf"
gam_unit_path = "/{network_id}/news/{section}"   # or a literal path
div_id = "ad-atf-"            # treated as a prefix; matches e.g. ad-atf-0
page_patterns = ["/", "/news", "/news/*"]
formats = [{ width = 300, height = 250 }]

# optional provider hints
[creative_opportunities.slot.providers.aps]
slot_id = "atf"

Generate slots from a live site (needs local Chrome/Chromium)

# Crawl the site's sections and write [creative_opportunities] in place
ts audit ad-templates generate https://www.example.com/

ts audit ad-templates generate https://www.example.com/ --dry-run    # preview, no write
ts audit ad-templates generate https://www.example.com/ --replace    # overwrite instead of merge

# Bound the crawl
ts audit ad-templates generate https://www.example.com/ --max-sections 20 --max-pages 41
ts audit ad-templates generate https://www.example.com/ --max-pages 1   # single page, as before

# Set the patterns yourself; disables pattern inference
ts audit ad-templates generate https://www.example.com/ \
  --page-pattern '/' --page-pattern '/news' --page-pattern '/news/*'

# Check whether the publisher splits ad units by device
ts audit ad-templates generate https://www.example.com/ --profiles desktop,mobile

# Behind bot protection: carry a session, pace the crawl, or use a visible browser
ts audit ad-templates generate https://www.example.com/ \
  --cookie '<NAME>=<VALUE>' --page-delay-ms 1500
ts audit ad-templates generate https://www.example.com/ --headful

Re-running merges: a slot seen again keeps its hand-tuned fields and gains this run's patterns and newly observed formats, and a hand-written gam_unit_path template is preserved. --replace discards existing slots, including any template written by hand.

Consent platforms. Publishers gate slot definition behind their consent platform, and the audit runs in a throwaway profile with no consent cookie — so such a site would define no slots at all and look identical to a site with no ad stack. The crawl therefore answers the two IAB interfaces every compliant platform exposes (TCF v2 and US Privacy) as a consenting, out-of-scope reader, before any page script runs. This changes only what the audit browser sees. --no-assume-consent observes the un-consented page instead.

Auditing a production hostname served locally. ts dev proxy serves a production hostname from a local Trusted Server; auditing through it keeps the page's origin, cookie scope, and any origin checks in the ad stack matching production rather than localhost:

ts dev proxy --map www.example.com=127.0.0.1:7676 --upstream-plaintext --rewrite-host

ts audit ad-templates generate https://www.example.com/ \
  --browser-proxy 127.0.0.1:18080 --danger-accept-invalid-certs

Note that a local Trusted Server injects its own configured slots, so a run through the proxy can rediscover config it already has; slot ids absent from the current config are the publisher's own.

When generation keeps literal paths, and when it refuses

Situation	Result
Only one page was crawled	Literal path — one observation cannot distinguish a literal from a template
The ad unit never varied by section	Literal path
A section's slug is not derivable from its URL	Refused slot omitted; the failed round-trip is reported
No root page was seen, so section_root is unknown	Refused slot omitted rather than guessing a fallback
Two path segments could both be the section	No template; the ambiguity is reported
The unit varies by device, geo, or anything the URL cannot supply	Refused slot omitted with the conflicting evidence reported
Several slots are one placement under per-render div ids	Fragments reported and skipped, with the stable prefix they share
Crawled pages report different GAM network ids	Run fails — the pages are not one property
More than a quarter of crawled pages return no slots	Run fails — the signature of bot protection serving challenge pages

Static diagnostics (no browser)

# Summarize config + deploy-time implications
ts config ad-templates lint

# Which configured slots match a path (or full URL)
ts config ad-templates match /news/story --details

# CI assertion: exact expected slot set
ts config ad-templates check /news/story --expected-slot atf
ts config ad-templates check /weather --expect-no-slots
ts config ad-templates check /news/story --expected-slot atf --allow-extra-slots

# Explain the runtime ad-stack gates for a modeled request
ts config ad-templates explain /news/story --bot --consent-denied --prefetch

Browser-backed audit (needs local Chrome/Chromium)

# Generic read-only page summary
ts audit page https://www.example.com/

# Verify configured slots render on live pages (DOM/GPT/APS evidence)
ts audit ad-templates verify https://www.example.com/news/story
ts audit ad-templates verify https://www.example.com/news/story --json
ts audit ad-templates verify https://www.example.com/ --strict --scroll

# Carry a session past an origin challenge (repeatable)
ts audit ad-templates verify https://www.example.com/ --cookie '<NAME>=<VALUE>'

# Allow a known redirect between your own properties (e.g. apex → www)
ts audit ad-templates verify https://example.com/ --allow-cross-origin-redirect

# Point at a specific browser / tune settle timing
ts audit ad-templates verify https://www.example.com/ \
  --chrome /path/to/chrome --settle-quiet-ms 1000 --settle-max-ms 15000

Shared config flags (all of the above)

--app-config <path>     # default: <app.name>.toml beside edgezero.toml
--manifest <path>       # default: edgezero.toml
--no-env                # skip the app-config environment overlay

Exit behavior

• Default verify is auditor-assist: exits 0 even with missing/partial evidence.
• --strict exits 1 when a confirmable matched slot is missing or partially confirmed; video, native, and out-of-page slots are unconfirmable and do not fail the gate. A page-level navigation failure, or a redirect that leaves the requested origin, also exits non-zero.
• Runtime gates (e.g. [auction].enabled = false) mark a page "skipped" so --strict does not fail it.

Local live test (deterministic, no external site)

Many large ad publishers block headless/non-evasive browsers, so verify against them sees a challenge page rather than the article (this tool does not evade bot detection — --cookie forwards a clearance a human already earned, and --headful runs a visible browser). When a page comes back without slots, the run now reports GPT's observable state — whether the library reached apiReady, how many queued commands never drained, how many scripts ran — which distinguishes "the library never loaded" from "this page has no ads".

To exercise the full pipeline reliably without an external site, serve a local fixture:

# 1. Fixture page that stubs just enough GPT (no network), served over HTTP
mkdir -p demo/news
cat > demo/news/story.html <<'HTML'
<!doctype html><html><head><meta charset="utf-8">
<div id="ad-atf-0"></div>
<script>
(function(){var s=[];var gt={cmd:[]};
gt.defineSlot=function(p,z,d){var o={getAdUnitPath:function(){return p},getSlotElementId:function(){return d},getSizes:function(){return z.map(function(x){return {getWidth:function(){return x[0]},getHeight:function(){return x[1]}}})}};s.push(o);return o};
gt.pubads=function(){return {getSlots:function(){return s}}};var op=gt.cmd.push.bind(gt.cmd);gt.cmd.push=function(c){op(c);c()};
window.googletag=gt;googletag.cmd.push(function(){googletag.defineSlot('/123/news/atf',[[300,250]],'ad-atf-0')});})();
</script></head><body></body></html>
HTML
(cd demo && python3 -m http.server 8771 &)

# 2. Verify against it (config from the example above, with page_patterns ["/news/*"])
ts audit ad-templates verify http://127.0.0.1:8771/news/story.html --json
#   => slots[0].status == "confirmed"

For a realistic end-to-end generation run, ts dev proxy in front of a local Trusted Server is the reliable path — see the proxy example above.

Checklist

• Changes follow CLAUDE.md conventions
• No unwrap() in production code — use expect("should ...")
• No println!/eprintln! in library code (CLI output uses writeln!; errors use log)
• New code has tests
• No secrets or credentials committed

[aram356]

Summary

Round-3 re-review at 09b7e4a7f. The resolution work is thorough: all 17 blocking findings from the previous review are addressed — 15 verified fixed outright (several by re-running the original reproductions), and most non-blocking carry-overs closed. Requesting changes for what this round introduced or left half-done: the config loader now silently swallows an unparseable [creative_opportunities] and overwrites the operator's slots, the new volatile-collision refusal is page-local and cannot distinguish a re-rendered element from two siblings (probed: a React SSR+hydration publisher generates zero slots), real-world identifiers re-entered the branch (Autoblog in a new spec, a hardcoded rh-gam-kso vendor rule that under-covers its own vendor), the CRLF scanner still mis-tracks triple quotes in comments (probed: a CRLF config silently flips to LF), and the 1024→128 evidence cap turns silent truncation into false --strict drift.

10 of the inline comments below carry a one-click GitHub suggestion — use Commit suggestion (or Add suggestion to batch) to apply them as commits on the PR branch. Every suggestion was verified in a scratch worktree: applied in isolation and as a batch, with cargo fmt --all -- --check, cargo clippy -p trusted-server-cli --target aarch64-apple-darwin --all-targets -- -D warnings, the full host CLI test suite (420 passed, 0 failed), and docs prettier all clean, with byte-exact post-verification drift checks. The remaining comments describe fixes in prose because the change spans multiple files, non-contiguous regions, or a design decision.

Blocking

🔧 wrench

• Unparseable [creative_opportunities] treated as absent — generate overwrites the operator's slots — see inline at crates/trusted-server-cli/src/commands/audit/mod.rs:323
• Collision refusal is page-local; another page rescues the ambiguous prefix — see inline at crates/trusted-server-cli/src/commands/audit/generate/gpt_slots.rs:183
• One element under two render tokens is refused as a collision — see inline at crates/trusted-server-cli/src/commands/audit/generate/gpt_slots.rs:197
• Hardcoded rh-gam-kso customer/vendor identifier under-covers its own vendor — see inline at crates/trusted-server-cli/src/commands/audit/generate/gpt_slots.rs:220
• Real publisher named in the new spec doc — see inline at docs/superpowers/specs/2026-08-19-refuse-volatile-div-collisions-design.md:43 (suggestion)
• Guide contradicts code and spec on out-of-page slots — see inline at docs/guide/cli.md:410 (suggestion)
• 128-entry evidence cap: silent truncation reads as --strict drift — see inline at crates/trusted-server-cli/src/commands/audit/ad_template_collector.js:31 (suggestion)
• check prints unescaped config-derived slot ids — see inline at crates/trusted-server-cli/src/commands/config/ad_templates.rs:478 (suggestion)
• CRLF scanner desynchronized by a triple quote in a comment or single-line string — see inline at crates/trusted-server-cli/src/commands/audit/generate/slot_toml.rs:581 (suggestion)
• Any two-letter section root is misread as a locale — see inline at crates/trusted-server-cli/src/commands/audit/generate/crawl_plan.rs:346

❓ question

• validate_merge_policy refuses the first merge onto a hand-written templated config — see inline at crates/trusted-server-cli/src/commands/audit/generate/mod.rs:1027

Non-blocking

🤔 thinking / ♻️ refactor / ⛏ nitpick

• 🤔 Generate silently follows the root redirect it now accepts — see inline at crates/trusted-server-cli/src/commands/audit/generate/mod.rs:603 (suggestion)
• ♻️ Index-document-only sections vanish instead of collapsing to the parent — see inline at crates/trusted-server-cli/src/commands/audit/generate/crawl_plan.rs:304
• ♻️ Userinfo leaks into stderr notes and the cross-origin refusal — see inline at crates/trusted-server-cli/src/commands/audit/generate/mod.rs:588
• ♻️ Remaining per-page report_error paths still double-log — see inline at crates/trusted-server-cli/src/commands/audit/generate/browser_collector.rs:560
• ♻️ consent_stub_active emitted per page × profile — see inline at crates/trusted-server-cli/src/commands/audit/generate/browser_collector.rs:563
• ♻️ Legacy ts audit generate exposes no browser flags or consent opt-out — see inline at crates/trusted-server-cli/src/commands/audit/mod.rs:303
• ♻️ Known-per-render registry branch seeds the collision map with an unnormalized raw — see inline at crates/trusted-server-cli/src/commands/audit/generate/gpt_slots.rs:130
• ⛏ Refusal table lacks rows for both new refusal classes — see inline at docs/guide/cli.md:241 (suggestion)
• ⛏ Always-on stderr progress output is undocumented — see inline at docs/guide/cli.md:246 (suggestion)
• ⛏ CLI manifest dependency ordering — see inline at crates/trusted-server-cli/Cargo.toml:20 (suggestion)
• ⛏ Dry-run "no changes" sentence lands on machine-readable stdout; diff computed before the equality check — see inline at crates/trusted-server-cli/src/commands/audit/generate/mod.rs:744 (suggestion)

Cross-cutting / body-level findings

• 🔧 Companion edits the suggestions above cannot carry (fold into the same fixes): browser.rs:43's MAX_EVIDENCE_ENTRIES = 1024 is now 8× the JS cap with nothing linking the two — align it with __ts_max_entries or comment the difference; the stale out-of-page claims also live in docs/superpowers/specs/2026-08-18-pr-823-review-resolution-design.md:135-138 and docs/superpowers/plans/2026-06-26-server-side-ad-template-cli.md:1069, 1264; and rh-gam-kso also appears throughout docs/superpowers/specs/2026-08-19-refuse-volatile-div-collisions-design.md and its plan.
• 🌱 Consent-stub residual risk: the no-op setter fixes strict-mode assignment, but a CMP that installs via Object.defineProperty(window, "__tcfapi", …) still throws on the non-configurable property, and the stubbed property is non-enumerable unlike a real global. Same class: __ts_install's window.googletag accessor is non-enumerable, so Object.keys(window) no longer lists it — the fingerprint moved rather than disappearing.
• 🌱 Dead/stale debt (pre-existing, grouped): verify_round_trip's mismatch arm is provably dead (instrumented across the full suite) while its doc calls it "the gate", now directly contradicted by the round-3 test comment at unit_template.rs:619; explain's unknown verdict arm is unreachable (config/ad_templates.rs:334, 385); gam_unit_path_unrenderable fires only for hand-built fixtures (compare.rs:270-279); VerificationReport.warnings is still always empty (audit/ad_templates.rs:163); ExtraEvidence.kind docs still promise dom/aps (compare.rs:191); the aps_calls plumbing survives with a now-false dead_code reason (compare.rs:50-53) and a stale JS header comment (ad_template_collector.js:3-4); page.rs still has zero tests and one unescaped field (final url:); non-derivable-slug refusals report only the generic "several ad-unit paths" reason, so the guide's "the reason is reported" overstates what the operator sees.
• ⛏ Grouped nits: the 08-19 spec under-specifies the recognizer (only inarticle_<n>/overlay_<n> qualify; -container is stripped first); browser_fixture_available duplicated verbatim in two test modules; the resource-timing buffer size literal written twice (generate/browser_collector.rs:36 vs the inline 100000 in the init script); GenerateBrowserOpts dropped the DANGEROUS rationale from --danger-accept-invalid-certs's doc; host_cookie evaluates and discards host_str() and embeds the full URL (query/fragment/userinfo) where only the origin is load-bearing; ControlFlow::Stop's doc still promises to stop a crawl the buffering collector has already finished; the default collect_site aborts on a root failure while the browser implementor folds it; the Loading progress line prints before the pacing sleep; redirected now fires on fragment-only differences; derive_section is pub in core with zero consumers; load_file_settings is pub under #[cfg(test)]; fractional sizes are mislabeled "non-numeric"; several new helpers lack doc comments and several new tests use bare asserts (gpt_slots.rs:211-244, crawl_plan.rs:55, 337-354, and the assert sites listed in the review threads); compare.rs:48 cross-references a spec section that now states the opposite; the TOCTOU window between the pre-write re-read and temp.persist() is fine but deserves the comment that was promised.

CI Status

• Analyze (actions): PASS
• Analyze (javascript-typescript): PASS (×2)
• Analyze (rust): PASS
• CodeQL: PASS
• browser integration tests: PASS
• cargo check (cloudflare native + wasm32-unknown-unknown): PASS
• cargo check/build/test (spin native + wasm32-wasip1): PASS
• cargo fmt: PASS (required)
• cargo test: PASS (required)
• cargo test (axum native): PASS
• cargo test (cross-adapter parity): PASS
• cargo test (ts CLI, native): PASS
• format-docs: PASS (required)
• format-typescript: PASS (required)
• integration tests: PASS
• integration tests (Fastly EC lifecycle): PASS
• prepare integration artifacts: PASS
• vitest: PASS

Local verification at 09b7e4a7f: host CLI suite 420 passed / 0 failed; cargo clippy -p trusted-server-cli --all-targets -- -D warnings clean; core wasm32-wasip1 clippy clean; cargo build -p trusted-server-cli --target wasm32-wasip1 clean.

[aram356]

Summary

Round-4 re-review at 073d5644a. The previous round is fully resolved: all 11 blocking findings and the non-blocking set verified fixed, with the original reproductions re-run (site-wide collision verdicts, residue-based re-render separation, the vendor const replaced by a shape detector, the comment/string-aware CRLF scanner, the ISO-639-1 locale gate, and creative_config refusing present-but-unparseable sections). The branch is clean of real-world identifiers. Requesting changes for a small set this round introduced: the redirect note degenerates to ``from / to `/```` on the http→https case, the legacy flatten publishes seven silently-ignored flags on `ts audit`, `--page-pattern` bypasses the root-less templating feature's safety invariant while its diagnostic asserts the invariant holds, and generate's settle cap silently changed 12s→10s — plus one question on merge policy.

8 of the inline comments below carry a one-click GitHub suggestion — use Commit suggestion (or Add suggestion to batch) to apply them. Every suggestion was verified in a scratch worktree, in isolation and as a batch: cargo fmt --all -- --check, cargo clippy -p trusted-server-cli --target aarch64-apple-darwin --all-targets -- -D warnings, the CLI test suites (402 lib tests; 202 generate tests on the touched paths), and docs prettier, all clean with byte-exact drift checks. The remaining comments describe fixes in prose because the change spans files or is a design decision.

Blocking

🔧 wrench

• Redirect note renders ``from / to `/```` for scheme/host changes — see inline at `crates/trusted-server-cli/src/commands/audit/generate/mod.rs:619` (suggestion)
• Legacy flatten publishes seven silently-ignored browser flags on ts audit — see inline at crates/trusted-server-cli/src/commands/audit/mod.rs:95
• --page-pattern bypasses the root-less templating safety invariant — see inline at crates/trusted-server-cli/src/commands/audit/generate/mod.rs:1143
• Settle constants dead; generate's cap silently 12s→10s — see inline at crates/trusted-server-cli/src/commands/audit/generate/browser_collector.rs:26

❓ question

• Explicit section_segment adopted silently when section_root is unset — see inline at crates/trusted-server-cli/src/commands/audit/generate/mod.rs:1099

Non-blocking

🤔 thinking / ♻️ refactor / ⛏ nitpick

• ♻️ Per-slot refusal reason still blames "none generalized" on the root-unwitnessed path — see inline at crates/trusted-server-cli/src/commands/audit/generate/unit_template.rs:184 (suggestion)
• ♻️ fold_collected dedupe is unconditional and lossy across profiles — see inline at crates/trusted-server-cli/src/commands/audit/generate/mod.rs:956
• 🤔 is_per_render_token claims date-prefixed stable segments — see inline at crates/trusted-server-cli/src/commands/audit/generate/gpt_slots.rs:282
• ⛏ creative_config defers whole-document syntax errors past the crawl — see inline at crates/trusted-server-cli/src/commands/audit/mod.rs:349
• ⛏ Nothing enforces MAX_EVIDENCE_ENTRIES == __ts_max_entries — see inline at crates/trusted-server-cli/src/commands/audit/browser.rs:45
• ⛏ page.rs escaping test is vacuous for the line it names — see inline at crates/trusted-server-cli/src/commands/audit/page.rs:131
• ⛏ Spec example still lists the sidebar as omitted — see inline at docs/superpowers/specs/2026-08-19-refuse-volatile-div-collisions-design.md:70 (suggestion)
• ⛏ Guide implies section_segment alone trips the merge refusal — see inline at docs/guide/cli.md:279 (suggestion)
• ⛏ Plan overstates the recognizer's positional rule — see inline at docs/superpowers/plans/2026-08-19-refuse-volatile-div-collisions.md:75 (suggestion)
• ⛏ expect message form / missing field doc / missing blank line — see inline at crates/trusted-server-cli/src/commands/audit/generate/mod.rs:1712, :102, and crates/trusted-server-cli/src/commands/audit/generate/browser_collector.rs:169 (suggestions)

Cross-cutting / body-level findings

• 📝 No plan/spec pair accompanies the root-less templating commit (78c0db453): every other behavior change in this PR ships a dated design pair (contiguous slot tables, review resolutions, pre-navigation cookies, generation progress, volatile-div collisions). This one changes SlotAnalysis semantics, adds a borrowed-section_root diagnostic, and rewrites a documented refusal row with no design doc. Add a short pair, or note why the review-resolution plan covers it.

CI Status

• Analyze (actions): PASS
• Analyze (javascript-typescript): PASS (×2)
• Analyze (rust): PASS
• CodeQL: PASS
• browser integration tests: PASS
• cargo check (cloudflare native + wasm32-unknown-unknown): PASS
• cargo check/build/test (spin native + wasm32-wasip1): PASS
• cargo fmt: PASS (required)
• cargo test: PASS (required)
• cargo test (axum native): PASS
• cargo test (cross-adapter parity): PASS
• cargo test (ts CLI, native): PASS
• format-docs: PASS (required)
• format-typescript: PASS (required)
• integration tests: PASS
• integration tests (Fastly EC lifecycle): PASS
• prepare integration artifacts: PASS
• vitest: PASS

Local verification at 073d5644a: CLI suites 402 lib + 232 audit-scoped tests passed, 0 failed; clippy -D warnings clean; fmt clean; docs prettier clean under the locked 3.8.1.

[aram356]

Summary

Round-5 re-review at 33a654e03. The previous round is fully resolved: the --page-pattern bypass is closed by threading borrowed_section_root out of inference and refusing before any write (with an end-to-end test asserting the config file stays byte-identical), the seven legacy browser flags are hidden behind requires = "legacy_url" with pass-through verified against the built binary, the settle constants are unified behind GENERATE_SETTLE_* restoring the intended 12s cap, the section_segment merge guard and profile-scoped diagnostics landed with tests, config syntax errors fail before any browser launches, and the previously undocumented feature commit now has its design pair. Requesting changes for one bug this round introduced — the malformed-config error prints its seven-line block twice — plus a set of precision and test-hardening items on the new code.

6 of the inline comments below carry a one-click GitHub suggestion. Every suggestion was verified in a scratch worktree, in isolation and as a batch: cargo fmt --all -- --check, cargo clippy -p trusted-server-cli --target aarch64-apple-darwin --all-targets -- -D warnings, the CLI test suites (411 lib tests; 205 generate-scoped on the touched paths), and docs prettier, all clean with byte-exact drift checks. The remaining comments describe fixes in prose because the change needs a second edit outside the range or is a judgement call.

Blocking

🔧 wrench

• Malformed-config error prints twice (report_error in a cli_error file) — see inline at crates/trusted-server-cli/src/commands/audit/mod.rs:413

Non-blocking

♻️ refactor / ⛏ nitpick

• ♻️ Borrowed-root refusal ignores fragment-skipped slots and over-refuses pattern sets — see inline at crates/trusted-server-cli/src/commands/audit/generate/mod.rs:1154 (suggestion)
• ⛏ Crawl-gap refusal reason can contradict the run-level ambiguity diagnostic — see inline at crates/trusted-server-cli/src/commands/audit/generate/unit_template.rs:182 (suggestion)
• ⛏ cli.md example comment describes the borrowed-root case as an exception, not a failure — see inline at docs/guide/cli.md:265 (suggestion)
• ⛏ Parent-flag rejection test asserts only is_err() — see inline at crates/trusted-server-cli/src/run.rs:440 (suggestion)
• ⛏ No Command::debug_assert() over the 13 requires string ids — see inline at crates/trusted-server-cli/src/run.rs:438 (suggestion)
• ⛏ Cap-invariant test coupled to JS punctuation, not the value — see inline at crates/trusted-server-cli/src/commands/audit/browser.rs:936 (suggestion)
• ⛏ page/verify settle defaults remain two unlinked sources of truth — see inline at crates/trusted-server-cli/src/commands/audit/collector.rs:46
• ⛏ Hidden <LEGACY_URL> surfaces in the rejection message — see inline at crates/trusted-server-cli/src/commands/audit/mod.rs:59
• ⛏ Grouped: undocumented sibling browser field; help test pins 3 of 7 flags; test name understates — see inline at crates/trusted-server-cli/src/commands/audit/mod.rs:236

Note: the two run.rs suggestions target adjacent ranges (line 438 and lines 440-451) — apply them as a batch so the second anchors cleanly.

CI Status

• Analyze (actions): PASS
• Analyze (javascript-typescript): PASS (×2)
• Analyze (rust): PASS
• CodeQL: PASS
• browser integration tests: PASS
• cargo check (cloudflare native + wasm32-unknown-unknown): PASS
• cargo check/build/test (spin native + wasm32-wasip1): PASS
• cargo fmt: PASS (required)
• cargo test: PASS (required)
• cargo test (axum native): PASS
• cargo test (cross-adapter parity): PASS
• cargo test (ts CLI, native): PASS
• format-docs: PASS (required)
• format-typescript: PASS (required)
• integration tests: PASS
• integration tests (Fastly EC lifecycle): PASS
• prepare integration artifacts: PASS
• vitest: PASS

Local verification at 33a654e03: CLI 411 lib + integration suites passed, 0 failed; clippy -D warnings clean; fmt clean; docs prettier clean.

[ChristianPavilonis]

Summary

Reviewed the locked head revision 4c9777d14bf1f541f25cedd37770aa800e8668c6. CI and local validation pass. I found two medium-priority correctness issues in generation/merge behavior and one documentation-policy issue; details are inline.

[ChristianPavilonis]

Cross-origin redirects from non-root crawl pages are folded into generated config

The origin check protects only the first root navigation. Subsequent section pages pass their post-redirect final_url directly to fold_collected; the later-profile path does the same, including that profile's root page. A same-origin article URL that redirects elsewhere can therefore contribute foreign paths, GPT slots, formats, and ad-unit paths to template inference and the in-place rewrite. Host-scoped cookies are not leaked, but the generated config may bid against inventory from the redirect destination.

Apply origin_changed to every collected page before incrementing success counts or folding evidence. Please also add coverage for a redirected section page and a later-profile root redirect.

[ChristianPavilonis]

A newly appended slot can incorrectly absorb a later discovered slot

matching_slot_index searches the entire mutable merged list. Once this loop appends a discovered slot, its exact div_id becomes a prefix candidate for later discoveries. For example, first-seen ad-top absorbs later ad-top-sidebar; the later slot's GAM path and provider state are discarded, while only formats and patterns are unioned. The result depends on discovery order, and no broad-prefix diagnostic appears because claims are recorded only for indices from the original config.

Restrict prefix reconciliation to the original existing_slots slice, and match current-run additions only by exact identity or deduplicate them before merging. Please add an order-sensitive regression test with an unrelated existing slot plus ad-top and ad-top-sidebar.

[ChristianPavilonis]

Use a fictional publisher in this design document

This document names Autoblog here and again at line 95. CLAUDE.md requires fictional information in docs and prohibits real customer or publisher names. Please replace it with a fictional publisher or describe the behavior generically.