fix(ci): run DMV build in node_modules directory - #425
Conversation
pnpm --filter only works for workspace projects, not dependencies. Run the build directly in node_modules/dicom-microscopy-viewer instead. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
|
|
|
Overall Grade |
Security Reliability Complexity Hygiene |
Code Review Summary
| Analyzer | Status | Updated (UTC) | Details |
|---|---|---|---|
| JavaScript | Aug 14, 2026 12:54p.m. | Review ↗ |
Important
AI Review is run only on demand for your team. We're only showing results of static analysis review right now. To trigger AI Review, comment @deepsourcebot review on this thread.
📦 Firebase Preview - Using Published DMVThis preview is using the published
|
|
Visit the preview URL for this PR (updated for commit ceaeb79): https://idc-external-006--pr425-fix-dmv-build-in-nod-4li909ro.web.app (expires Fri, 21 Aug 2026 12:56:27 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 88aacecd98ba54d2f9c8d201a9444e43d1ad8307 |



Summary
Fixes the DMV build command in the Firebase deploy workflow.
pnpm --filteronly works for workspace projects, not dependencies innode_modules.Problem
The previous command
pnpm --filter dicom-microscopy-viewer run buildfails with:Solution
Run the build directly in the node_modules directory:
(cd node_modules/dicom-microscopy-viewer && pnpm run build)Test plan
🤖 Generated with Claude Code
Co-Authored-By: Claude Opus 4.5 noreply@anthropic.com