Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Backend changes corresponding to InetIntel/grip-ui#25 - Nesting of tags is being done for
eventandpfx_eventendpoints in order for the frontend to consume and display details for the same with ease.As discussed, the groupings should be on irr-[IRR]-[common_suffix] families of tags, where:
The GET calls for these endpoints have a version endpoint. If set to 'v2', we get the new, modified responses which would look like:
{ "all-newcomer-exact-record": [ "irr-ARIN-all-newcomer-exact-record", "irr-RADB-all-newcomer-exact-record", ... ], "all-newcomer-no-record": [...], ... "other": [list of other tags that don't follow the irr-[IRR_name/all]-[suffix] format] }Additionally, the
/tagsendpoint will have an additional key callednested_tag_descriptions, which will have descriptions for the parent tag (to display on the parent tag tooltips).Testing
API testing pending.
Issues
InetIntel/grip-ui#25