fix(mars): use HPCC bfloat/fp16 headers instead of MACA - #46
Merged
Conversation
Mars links the HPCC toolkit, so TypeMap must include hpcc_bfloat16.h and alias cuda_bfloat16 to __hpcc_bfloat16.
voltjia
approved these changes
Aug 24, 2026
This was referenced Aug 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
src/native/cuda/mars/data_type_.hfrom MACA (maca_bfloat16.h,maca_fp16.h,__maca_bfloat16) to HPCC (hpcc_bfloat16.h,hpcc_fp16.h,__hpcc_bfloat16).cuda_bfloat16/cuda_bfloat162aliases to the HPCC bfloat types for Mars.Motivation
Mars/HPCC builds link the HPCC toolkit, not MACA. The Mars backend landed on
masterwith MetaX-style MACA half/bfloat headers; that breaks or mis-types Mars builds that compile against/opt/hpccincludes. This aligns MarsTypeMapwith the actual vendor headers.Related InfiniOps Mars stack (platform/kernels/smoke): InfiniTensor/InfiniOps#941–#943.
Type of Change
feat- new feature / new backend capability / new public APIfix- bug fixperf- performance improvement without behavior changerefactor- code restructuring without behavior changetest- adding or fixing tests onlydocs- documentation onlybuild/ci- build system or CI configurationchore- tooling, formatting, or other non-code changes!in the Conventional Commits prefix or aBREAKING CHANGE:footer)Platforms Affected
WITH_CPU)WITH_NVIDIA)WITH_ILUVATAR)WITH_HYGON)WITH_METAX)WITH_MOORE)WITH_CAMBRICON)WITH_ASCEND)Note: Mars / HPCC (
WITH_MARS) — Mars dtype header fix only.Smoke Build and Test Result
Host: MetaX X203 / HPCC (Mars integration prefix).
Test Results on Supported Platforms
WITH_MARS)WITH_MARS=ON)Full `ctest` output (optional)
Benchmark / Performance Impact
N/A
Notes for Reviewers
WITH_MARS=ONagainst HPCC before pointingINFINI_RT_ROOTat the prefix.