Add category and payment fields for bills - #103
Open
magshee wants to merge 1 commit into
Open
Conversation
Contributor
Author
|
Merging this would also fix the problem addressed in #98 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First of all, sorry for the long wait. I got a little busier than expected in the last weeks. Also I kind of ran too far on my first attempt, which resulted in changing more code than necessary for this PR. I threw my original branch away and started all over.
How this works
Category and payment tags are shipped via the general project endpoint. Every time when bills and members are loaded, we also load the category and payment tags. If they are not available for some reason, this does not cause the bill details to not show. Simply the picker for both category and payment tag is not shown then. Existing id's for both are kept upon updating in that case.
Design
The current design is like this, but feel free to propose changes.
Final note
This PR also fixes a bug where a reoccuring bill is set to non-reoccuring after it is edited in PayForMe.
I used claude code to get a better understand of the cospend API, translations, as well as for getting test coverage and figuring out what weird behaviour may appear, in order to get the best result possible. I am aware that the solution may still not be optimal. However, I thought that even a suboptimal solution may be better than waiting for anything at all.
I am still happy to be able to present something here, thanks for your patience!