fix(dashboard): authenticate frontend API calls with X-WB-Token - #31
Open
petarkrvavac wants to merge 1 commit into
Open
fix(dashboard): authenticate frontend API calls with X-WB-Token#31petarkrvavac wants to merge 1 commit into
petarkrvavac wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The dashboard backend requires the per-launch
X-WB-Token, but frontend API requests were being sent without the token, causing401 Unauthorizedresponses.Fix
ensureToken()/withAuth()helpers insrc/auth.tsso the frontend uses a single token cache.src/api.tssoj()andrunAgent()sendX-WB-Token.src/v2/api.tsso bothrequest()and thestreamEvents()SSE fetch use the same auth helper.Accept: text/event-streamheader for SSE requests./api/sessionremains unauthenticated because it is the bootstrap endpoint used to obtain the per-launch dashboard token.Verification
401responses.npm run buildsucceeds.