Improve waterfall motion and soften the lower splash transition - #27
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The running garden waterfall barely moved vertically, while its periodic highlight generator could create horizontal white bands. Replace that highlight carrier with restrained irregular color variation and two staggered downstream texture passes. Each pass travels 20 source-image pixels at 48 pixels/second and resets only at zero blend weight; a plain triangular blend avoids a bobbing sampling centroid.
Feather the lower ends over up to 24 source pixels and extend the bottom curtain into its splash zone, joining the pool instead of leaving a still strip above the foam. Source waterfall masks limit transported ledge detail. These are decorative image-space effects, not a fluid simulation. Existing layout, deer, pool motion and lifecycle controls remain unchanged. Cache v99 includes the updated script.
Validation: nine existing local commands pass, including syntax and home/navigation/runtime checks plus unchanged deer geometry/lifecycle tests. Windows Chromium compiled and ran the updated shader; successive rendered frames, still-versus-running views, pause/resume and a 390px phone viewport were inspected. Shader math also received an independent review. Native Safari/macOS and real-phone GPU performance are unverified; the existing unit tests do not establish shader visual quality.