fix(homegrown): close post-merge soft-hold races (TIN-2764) - #119
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
PR #118 merged before its adversarial review corrections were committed. This follow-up lands the confirmed post-merge safety fixes without rewriting the merged history.
Changes
SLOT_TAKENbefore payment while stripping any caller-supplied hold id from the standard checkout pipelineReview and validation
pnpm check: 0 errors, 0 warningspnpm lintpnpm test:unit: 876 passedpnpm test:integration: 34 passed, 5 Postgres tests skipped locally withoutDATABASE_URLpnpm buildpnpm check:package: publint all goodnix develop --command pnpm docs:check: strict MkDocs build passedgit diff --checkMerge gate
The CI
Integration (Postgres service)job must run the five database tests, including the new concurrent-hold case, and pass before merge.Tracks TIN-2764.