chore(deps): bump JavaScriptKit to 0.56.1 in the wasm bridge - #1244
Merged
Merged
Conversation
Raises the wasm/ package floor from 0.53.0 (and swift-syntax moves 603.0.1 -> 603.0.2 transitively). Picks up the upstream Embedded-Swift fixes: JavaScriptEventLoop on newer toolchains (#784) and Embedded-compatible error descriptions (#759). JavaScriptKit's minimum Swift is now 6.3, which matches the pinned swift-6.3.2-RELEASE_wasm-embedded SDK. The rest of the 0.54-0.56 delta is BridgeJS work Chickadee does not use (the bridge is manual interop). Validated with the real toolchain: installed Swift 6.3.2 + the pinned Embedded wasm SDK, ran scripts/build-runner-wasm.sh — compiles clean with no bridge changes — and ran the browser contract suite (node --test Tests/BrowserRunnerJSTests) against the rebuilt artifact: 141/141 passing, including output-contract and the drift tests. Size: gzip 503910 bytes, +3006 (0%) vs baseline, within budget. Public/runner-wasm/ is deliberately NOT re-vendored in this PR: the runner-wasm-vendor workflow's source hash covers wasm/Package.resolved, so it rebuilds and commits the canonical artifact on main post-merge. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01SrX4NqzzxXSbQnu3XCFZM6
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Bumps the
wasm/sub-package's JavaScriptKit floor 0.53.0 → 0.56.1 (swift-syntax follows 603.0.1 → 603.0.2 transitively). Follow-up to #1242, which deliberately left this out.Relevant upstream changes:
JavaScriptEventLoopfix for newer toolchains (FixJavaScriptEventLoopfor Embedded Swift inmaintoolchain snapshots swiftwasm/JavaScriptKit#784) and Embedded-compatible error descriptions (build(wasm): add RunnerCore wasm bridge sub-package #759).swift-6.3.2-RELEASE_wasm-embeddedSDK.wasm/Sources/RunnerWasm/main.swift).Tested with the real toolchain
Installed Swift 6.3.2 + the pinned Embedded wasm SDK (exactly the
runner-wasm-vendorCI recipe) and ran the full pipeline locally:scripts/build-runner-wasm.sh— compiles clean, zero bridge changes needed (Embedded mode,Externfeature, Unicode-tables linkage all fine)node --test Tests/BrowserRunnerJSTestsagainst the rebuilt artifact — 141/141 passing, includingoutput-contract.test.mjsand the runtime/grading-worker drift testsWhy
Public/runner-wasm/is untouched hereBy design. The
runner-wasm-vendorworkflow's source hash coverswasm/Package.resolved; on merge it detects the drift, rebuilds with the canonical CI toolchain, and commits the re-vendored artifact to main itself (same pipeline as every RunnerCore change). Shipping container-built bytes from this PR would bypass that provenance. Note the documented one-release lag: the fresh artifact ships with the release after the vendor commit lands.🤖 Generated with Claude Code
https://claude.ai/code/session_01SrX4NqzzxXSbQnu3XCFZM6
Generated by Claude Code