Fix rig/DNA importer compilation (UE 5.8) - #92
Open
theNefelibatas wants to merge 1 commit into
Open
Conversation
- gate ControlRigBlueprint include on 5.7 (renamed ControlRigBlueprintLegacy.h) - gate RigLogic renames on 5.5 (GetNeutralJointValues, GetJointOutputs) - gate DnaFileName and FRigVMExecuteOp::CallableIndex on 5.8 - pass registry handle to factory and function lookups on 5.7+ - read the registry through FRigVMRegistry::Get on 5.8 (GetForRead removed) - point SkinWeightProfile.h at Rendering/ on 5.8
Member
|
Hey, thanks for the commit! At the moment, I don't want to accept compatibility fixes since I'm going to handle most of them myself. There are quite a few versions that need to be updated. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The Control Rig and DNA (RigLogic) importers fail to compile on UE 5.8
(C1083 / C2039 / C2660): the APIs they were written against were renamed,
moved, or removed by 5.8.
Changes
ControlRigBlueprint.h→ControlRigBlueprintLegacy.h(5.7): includes gated on the newUE5_7_BEYONDmacro inCompatibility.h.GetForRead()deleted → reads go throughFRigVMRegistry::Get();GetTypestays on the wrapper (_NoLockspellings are protected now).FRigVMExecuteOp::FunctionIndex→CallableIndex(5.8): the index moved to theFRigVMInvokeCallableOpbase.GetArgumentInfos/GetArgumentNameForOperandIndex(5.7): gained aFRigVMRegistryHandle¶meter; calls pass
FRigVMRegistry::Get().GetHandle_NoLock().UDNAAsset::DnaFileName→DnaFileName_DEPRECATED(5.8).Animation/SkinWeightProfile.h→Rendering/SkinWeightProfile.h(5.8).GetRawNeutralJointValues→GetNeutralJointValues,GetRawJointOutputs→GetJointOutputs.Verification
not introduced here.