Add experimental DummyOptimization and adopt new dev workflow - #116
Merged
Merged
Conversation
* Add the non-exported, experimental `QuantumControl.DummyOptimization` submodule with `dummy_control_problem` and the `:dummymethod` optimization method, moved from QuantumControlTestUtils (which no longer depends on QuantumControl). It includes private copies of the random-object generators, so that the same `rng` produces the same dummy problems. The API docs list it only in the reference, marked as experimental. * Adapt the tests to QuantumControlTestUtils 0.4: import `dummy_control_problem` from `QuantumControl.DummyOptimization`, pass the terms returned by `random_dynamic_generator` to `hamiltonian`, and drop the unused `QuantumTestLogger`. Fix the `sparsity` keyword in test_adjoint_trajectory.jl, which should be `density`. * Adopt the org-wide development workflow: standard Makefile, test environment reduced to what the tests use, no devrepl.jl, new CI with a lowest-compat job on the oldest supported Julia. The downstream GRAPE/Krotov workflows now test their master branches against the current QuantumControl via Pkg.develop. * Docs: take QuantumPropagators from its master branch via [sources] until the next QuantumPropagators release (v0.9.0 has a broken cross-reference). Add Documenter remotes for URL-sourced packages, so source links point to GitHub. * Add two ExternalFallbacks for `Krotov-Background` and `storage-contract`.
Codecov Report❌ Patch coverage is
❌ Your patch check has failed because the patch coverage (65.4%) is below the target coverage (90.0%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## master #116 +/- ##
========================================
- Coverage 87.8% 84.4% -3.3%
========================================
Files 20 21 +1
Lines 1140 1342 +202
========================================
+ Hits 1000 1132 +132
- Misses 140 210 +70 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
The tests import the `Random` standard library, which was missing from `test/Project.toml`. `make test` did not catch this because the default `LOAD_PATH` includes the standard library and the global environment, while `Pkg.test` on CI only sees the test environment. `make test` and `make coverage` now set `JULIA_LOAD_PATH="@"` and `--startup-file=no`, so that a dependency missing from `test/Project.toml` is an error locally as well.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
QuantumControl.DummyOptimizationmodule, which replacesQuantumControlTestUtils.DummyOptimizationThe documentation environment temporarily takes QuantumPropagators from its
masterbranch (via[sources]), because v0.9.0 has a broken cross-reference. CI shows an "Unreleased sibling package" warning for this. Remove the entry after the next QuantumPropagators release.