fix: upgrade Gradle and plugins for Java 25 compatibility - #298
Open
postyizhan wants to merge 4 commits into
Open
fix: upgrade Gradle and plugins for Java 25 compatibility#298postyizhan wants to merge 4 commits into
postyizhan wants to merge 4 commits into
Conversation
postyizhan
force-pushed
the
fix/gradle-java25-compatibility
branch
from
August 19, 2026 02:10
db44b57 to
f270e1e
Compare
This reverts commit f270e1e.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Background
The original project setup uses outdated Gradle and plugin versions that are incompatible with Java 25. Attempting to build the project with the default configuration results in build failures due to unsupported class file versions and plugin resolution issues.
Issues with original setup
com.gtnewhorizons.gtnhsettingsconventionplugin version 1.0.27 is incompatible with Java 25.dts.typescript-generatorplugin is referenced without a version and fails to resolve.Changes made
gtnhsettingsconventionplugin to 2.0.29 which supports Java 25.dts.typescript-generatorby enabling the resolution strategy and specifying version explicitly.archivesBaseNamewithbase.archivesNameto comply with Gradle's newer conventions.gradle-pluginsandsrc/api) to include all required code during build.CustomNpcs.javaby removing nonexistent methods and adjusting parameters.Verification
This PR ensures the project can be built and developed using a modern Java 25 environment, resolving critical compatibility blocks present in the original repo configuration.If you prefer to continue building with Java 8, please let me know, and I can help adjust the setup accordingly.