Support loading programs without needing a temporary directory - #477
Merged
gkreitz merged 3 commits intoAug 28, 2026
Merged
Conversation
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
pehrsoderman
approved these changes
Aug 28, 2026
pehrsoderman
left a comment
pehrsoderman
left a comment
Contributor
There was a problem hiding this comment.
There seems to be an issue breaking the check for file size. Should be easy to reproduce with a source file larger than 128 kiB. We should probably add some kind of test for this also.
I will approve this, and let you decide how to handle it.
gkreitz
force-pushed
the
make_programs_loadable_without_tmpdir
branch
from
August 28, 2026 09:30
848ef54 to
b989644
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Preparatory change for refactoring verifyproblem.
We used to require a tmpdir just to load programs, and programs would already in their constructor populate the temporary directory. This PR postpones creation of a temporary working directory until compile is called (which now takes the directory as argument).
As this change initially caused me to have to do
str(<path>)in a number of places where we callcompile, I took the opportunity to moveruna more towardsPathobjects too.