Replace verifyproblem classes with models + checks - #478
Merged
Conversation
gkreitz
force-pushed
the
verifyproblem_refactor
branch
from
August 28, 2026 11:08
850e875 to
ebf21f8
Compare
pehrsoderman
approved these changes
Aug 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This completes the large refactor of splitting verifyproblem into manageable chunks (models + checks) we can more easily work with going forward. Here, we remove all the
ProblemPartclasses (which were all seams at this point), and replace the whole thing with a thin new class,ProblemVerifier.There will be follow-up PR:s to fix and clean up things in various checks which I didn't do while extracting functions. My hope is that this is a better foundational design to work from (and cleaner to use as an API).
Added in adjusting the type of the temporary work directory we set up for checking to be
Path. As it's nowPathin verifyproblem, it ended up very silly to cast it to str to pass it to checks to there cast it back toPath.Fixes #398