Add more warnings about score ranges (and reject_score) - #484
Open
gkreitz wants to merge 4 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In these new checks, we compute max scores for test data groups based on the configuration of their children, and add several new warnings:
I decided not to add warnings if the computed range is larger than the declared range (e.g., 11 test cases worth 10 each, but the range says 0 100). This should be caught by out-of-bounds checks when running submissions. Happy to take opinions on if we want to check it statically here too.
Note that these checks all disappear when a custom grader is used (for obvious reasons). And if custom scoring is used, we can't make any assumptions regarding what each test case is worth, so the checks are less likely to catch stuff.
I also added an explicit warning for using
reject_score. It's been removed in the new format. I cannot think of a good use case, and it's always the default 0 in all of the problems ever installed on Kattis.Fixes #439