Minor model polish - NewType for absolute vs. relative paths, and narrowing program types - #487
Open
gkreitz wants to merge 2 commits into
Open
Minor model polish - NewType for absolute vs. relative paths, and narrowing program types#487gkreitz wants to merge 2 commits into
gkreitz wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Minor polish to our model classes. This is mainly for the sake of Kattis, but also in case others want to use model as a (still somewhat unstable) API.
Pathin model is nowAbsolutePathorRelativePathto clearly communicate which paths are absolute, and which are relative. For relative paths, you can figure out what they're relative to by looking at comments.SourceCode | BuildRun, instead of the base classProgram.Also fixes a documentation mistake, where a path was claimed to be relative, but no longer was (which influenced my choice to actually leverage the type system to communicate this, instead of just comments).