Migrate to JMLtk - #3966
Open
wadoon wants to merge 7 commits into
Open
Conversation
wadoon
added
JavaJMLParser
Feature
wadoon
marked this pull request as ready for review
August 16, 2026 23:48
Member
Author
|
Squash before merge |
unp1
requested changes
Aug 17, 2026
| @@ -1,4 +1,4 @@ | |||
| public record SimpleRecord(/*@ nullable */ String name) implements Serializable { | |||
| public record SimpleRecord([[JML modifiers]] String name) implements Serializable { | |||
| @@ -1,4 +1,4 @@ | |||
| public record SimpleRecord(/*@ nullable */ String name) implements Serializable { | |||
| public record SimpleRecord([[JML modifiers]] String name) implements Serializable { | |||
Member
There was a problem hiding this comment.
I think that should also be nullable
| @@ -1,4 +1,4 @@ | |||
| public record SimpleRecord(/*@ nullable */ String name) implements Serializable { | |||
| public record SimpleRecord([[JML modifiers]] String name) implements Serializable { | |||
| @@ -1,4 +1,4 @@ | |||
| public record SimpleRecord(/*@ nullable */ String name) implements Serializable { | |||
| public record SimpleRecord([[JML modifiers]] String name) implements Serializable { | |||
|
|
||
| @javax.annotation.processing.Generated("RecordClassBuilder") | ||
| private final /*@ nullable */ String name; | ||
| private final [[JML modifiers]] String name; |
|
|
||
| @javax.annotation.processing.Generated("RecordClassBuilder") | ||
| public final /*@ nullable */ String name() { | ||
| public final [[JML modifiers]] String name() { |
|
|
||
| @javax.annotation.processing.Generated("RecordClassBuilder") | ||
| private final /*@ nullable */ nullable String name; | ||
| private final [[JML modifiers]] /*@ nullable */ String name; |
|
|
||
| @javax.annotation.processing.Generated("RecordClassBuilder") | ||
| public final /*@ nullable */ nullable String name() { | ||
| public final [[JML modifiers]] /*@ nullable */ String name() { |
It is still a regression, as the reported token is now "int" and not "=" as before.
Member
|
Improved the position recording slightly. But the parser now reports "int" as last successfull token and no longer "=", so the position is no longer as precise as before where the dialog underlined the empty space after '=' |
Member
|
Sorry my fault, restored to open. First pushed to the wrong branch due to a typo jmtk and then deleted the correct one.... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Intended Change
With this PR,
wadoon/key-javaparserbecomes obsolete in favour of the JMLtk fork!This PR does not
Regressions:
ExpressionStmt(int x = ;)Changes to
key-javaparser/*@ ghost */ int x;)KeyRangeExpressiongoneKeyMarkerStatementgoneXStatementvs.XStmt)Plan
Things to do after review:
decide when to make JMLtk first release
Kcounter on JMLtkdiscuss sacrifices in JMLtk for KeY compat:
/*@ghost*/ int #x;vs.ghost int #x;How to proceed further with exchanging JML parsing
Type of pull request
Ensuring quality