KC-1434: Mask secrets consistently in service-mode command logs - #2320
Merged
Conversation
amangalampalli-ks
force-pushed
the
fix/service-log-secret-masking
branch
from
August 25, 2026 13:34
e131cdf to
d946859
Compare
amangalampalli-ks
marked this pull request as ready for review
August 25, 2026 13:39
craiglurey
approved these changes
Aug 25, 2026
sk-keeper
pushed a commit
that referenced
this pull request
Aug 25, 2026
sk-keeper
pushed a commit
that referenced
this pull request
Aug 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Secrets in service-mode command logs (passwords, TOTP codes, private keys, payment/bank data, etc.) were inconsistently masked. This fixes it so they're always hidden.
Changes