KC-1408: Treat first-time share invitations as success in Service Mode - #2325
Merged
Conversation
#2303) * Treat first-time share invitations as success in Service Mode * Use ShareInviteSentError so NSF invite success does not mask real share failures
Remove imports and tests for PAMDebugACLCommand and PAMDebugLinkCommand, which were deleted in commit 2f1447a. Update test file to only include tests for modules that still exist.
sshrushanth-ks
marked this pull request as ready for review
August 27, 2026 11:03
craiglurey
approved these changes
Aug 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixed Service Mode so first-time shares to users with no existing relationship return success after sending an invitation, instead of HTTP 500. The invite itself was working;
nsf-share-recordtreated the invitation notice as a hard error, andshare-folderalso loggedUser not found, which the Service Mode parser treated as failure. Invite success is now signaled with a distinctShareInviteSentErrorso genuine share failures are not masked.Changes
common.py/__init__.py: AddedShareInviteSentErrorand raised it fromhandle_share_inviteon successful invite sendsharing_commands.py: CaughtShareInviteSentErrorfornsf-share-recordand logged it as a warningfolder_commands.py: Narrowed thensf-share-foldercatch from broadValueErrortoShareInviteSentErrorregister.py: Stoppedshare-folderfrom loggingUser not foundafter a successful inviteparse_keeper_response.py: Treated “share invitation has been sent to” as success, with throttle and forbidden keeping precedencetest_nested_share_folder.py: Added invite-success and genuine-failure tests fornsf-share-record/nsf-share-foldertest_throttle_response.py: Added parser tests for invitation success and throttle/forbidden precedence