Feature/dns plugins

CHANGELOG.md

@@ -1,3 +1,11 @@
+v1.2.0
+- Added support for CSC TrustedSecure EV, Multiple Names; CSC TrustedSecure OV Wildcard, Multiple Names; and CSC TrustedSecure DV Wildcard, Multiple Names certificate products
+- Renamed all certificate template product IDs to match CSC's current certificate type names (e.g. "CSC TrustedSecure Premium Certificate" is now "CSC TrustedSecure OV", "CSC TrustedSecure Domain Validated SSL" is now "CSC TrustedSecure DV"). Existing Certificate Templates in Command using the old names continue to work; new Templates should use the new names.
+- Fixed the "Addtl Sans Comma Separated DCV Emails" enrollment field never actually being read during enrollment, due to a typo in the code looking up "DVC" instead of "DCV". Per-domain DCV emails for additional SANs on unrelated domains were silently ignored, falling back to the primary CN's DCV email - which does not have authority to validate a different domain.
+- Fixed a case-sensitivity bug ("priorcertsn" vs "PriorCertSN") that prevented PriorCertSN from ever being read during Renew/Reissue enrollment.
+- Fixed a crash when CSC Global returns a null "price.total" (e.g. reissuing a certificate that is not in an active status) - Price.Total is now nullable instead of causing a JSON deserialization exception.
+- Added an xUnit test suite covering certificate type/SAN/EV routing, legacy product name backward compatibility, and the fixes above.
+
 v.1.1.1
 - Added Incremental Sync that goes back X Number of days
 - Fixed issue with parsing certain certificates that were in zip format

README.md

@@ -96,16 +96,16 @@ If a field value is specified as both an Enrollment Field in Command and in the
 
 CONFIG ELEMENT				| DESCRIPTION
 ----------------------------|------------------
-Template Short Name	| CSC TrustedSecure Premium Certificate
-Template Display Name	| CSC TrustedSecure Premium Certificate
-Friendly Name	| CSC TrustedSecure Premium Certificate
+Template Short Name	| CSC TrustedSecure OV
+Template Display Name	| CSC TrustedSecure OV
+Friendly Name	| CSC TrustedSecure OV
 Keys Size  | 2048
 Enforce RFC 2818 Compliance | True
 CSR Enrollment | True
 Pfx Enrollment | True
 
 
-**CSC TrustedSecure Premium Certificate - Enrollment Fields**
+**CSC TrustedSecure OV - Enrollment Fields**
 
 NAME | DATA TYPE	| VALUES
 -----|--------------|-----------------
@@ -120,20 +120,20 @@ Business Unit | Multiple Choice | Get From CSC Differs For Clients
 Notification Email(s) Comma Separated | String | N/A
 CN DCV Email | String | N/A
 
-**CSC TrustedSecure EV Certificate - Details Tab**
+**CSC TrustedSecure EV - Details Tab**
 
 CONFIG ELEMENT				| DESCRIPTION
 ----------------------------|------------------
-Template Short Name	| CSC TrustedSecure EV Certificate
-Template Display Name	| CSC TrustedSecure EV Certificate
-Friendly Name	| CSC TrustedSecure EV Certificate
+Template Short Name	| CSC TrustedSecure EV
+Template Display Name	| CSC TrustedSecure EV
+Friendly Name	| CSC TrustedSecure EV
 Keys Size  | 2048
 Enforce RFC 2818 Compliance | True
 CSR Enrollment | True
 Pfx Enrollment | True
 
 
-**CSC TrustedSecure EV Certificate - Enrollment Fields**
+**CSC TrustedSecure EV - Enrollment Fields**
 
 NAME | DATA TYPE	| VALUES
 -----|--------------|-----------------
@@ -149,20 +149,20 @@ Notification Email(s) Comma Separated | String | N/A
 CN DCV Email | String | N/A
 Organization Country | String | N/A
 
-**CSC TrustedSecure UC Certificate - Details Tab**
+**CSC TrustedSecure OV, Multiple Names - Details Tab**
 
 CONFIG ELEMENT				| DESCRIPTION
 ----------------------------|------------------
-Template Short Name	| CSC TrustedSecure UC Certificate
-Template Display Name	| CSC TrustedSecure UC Certificate
-Friendly Name	| CSC TrustedSecure UC Certificate
+Template Short Name	| CSC TrustedSecure OV, Multiple Names
+Template Display Name	| CSC TrustedSecure OV, Multiple Names
+Friendly Name	| CSC TrustedSecure OV, Multiple Names
 Keys Size  | 2048
 Enforce RFC 2818 Compliance | True
 CSR Enrollment | True
 Pfx Enrollment | True
 
 
-**CSC TrustedSecure UC Certificate - Enrollment Fields**
+**CSC TrustedSecure OV, Multiple Names - Enrollment Fields**
 
 NAME | DATA TYPE	| VALUES
 -----|--------------|-----------------
@@ -179,20 +179,20 @@ CN DCV Email | String | N/A
 Addtl Sans Comma Separated DCV Emails | String | N/A
 
 
-**CSC TrustedSecure Premium Wildcard Certificate - Details Tab**
+**CSC TrustedSecure OV Wildcard - Details Tab**
 
 CONFIG ELEMENT				| DESCRIPTION
 ----------------------------|------------------
-Template Short Name	| CSC TrustedSecure Premium Wildcard Certificate
-Template Display Name	| CSC TrustedSecure Premium Wildcard Certificate
-Friendly Name	| CSC TrustedSecure Premium Wildcard Certificate
+Template Short Name	| CSC TrustedSecure OV Wildcard
+Template Display Name	| CSC TrustedSecure OV Wildcard
+Friendly Name	| CSC TrustedSecure OV Wildcard
 Keys Size  | 2048
 Enforce RFC 2818 Compliance | True
 CSR Enrollment | True
 Pfx Enrollment | True
 
 
-**CSC TrustedSecure Premium Wildcard Certificate - Enrollment Fields**
+**CSC TrustedSecure OV Wildcard - Enrollment Fields**
 
 NAME | DATA TYPE	| VALUES
 -----|--------------|-----------------
@@ -207,20 +207,20 @@ Business Unit | Multiple Choice | Get From CSC Differs For Clients
 Notification Email(s) Comma Separated | String | N/A
 CN DCV Email | String | N/A
 
-**CSC TrustedSecure Domain Validated SSL - Details Tab**
+**CSC TrustedSecure DV - Details Tab**
 
 CONFIG ELEMENT				| DESCRIPTION
 ----------------------------|------------------
-Template Short Name	| CSC TrustedSecure Domain Validated SSL
-Template Display Name	| CSC TrustedSecure Domain Validated SSL
-Friendly Name	| CSC TrustedSecure Domain Validated SSL
+Template Short Name	| CSC TrustedSecure DV
+Template Display Name	| CSC TrustedSecure DV
+Friendly Name	| CSC TrustedSecure DV
 Keys Size  | 2048
 Enforce RFC 2818 Compliance | True
 CSR Enrollment | True
 Pfx Enrollment | True
 
 
-**CSC TrustedSecure Domain Validated SSL - Enrollment Fields**
+**CSC TrustedSecure DV - Enrollment Fields**
 
 NAME | DATA TYPE	| VALUES
 -----|--------------|-----------------
@@ -235,20 +235,20 @@ Business Unit | Multiple Choice | Get From CSC Differs For Clients
 Notification Email(s) Comma Separated | String | N/A
 CN DCV Email | String | N/A
 
-**CSC TrustedSecure Domain Validated Wildcard SSL - Details Tab**
+**CSC TrustedSecure DV Wildcard - Details Tab**
 
 CONFIG ELEMENT				| DESCRIPTION
 ----------------------------|------------------
-Template Short Name	| CSC TrustedSecure Domain Validated Wildcard SSL
-Template Display Name	| CSC TrustedSecure Domain Validated Wildcard SSL
-Friendly Name	| CSC TrustedSecure Domain Validated Wildcard SSL
+Template Short Name	| CSC TrustedSecure DV Wildcard
+Template Display Name	| CSC TrustedSecure DV Wildcard
+Friendly Name	| CSC TrustedSecure DV Wildcard
 Keys Size  | 2048
 Enforce RFC 2818 Compliance | True
 CSR Enrollment | True
 Pfx Enrollment | True
 
 
-**CSC TrustedSecure Domain Validated Wildcard SSL - Enrollment Fields**
+**CSC TrustedSecure DV Wildcard - Enrollment Fields**
 
 NAME | DATA TYPE	| VALUES
 -----|--------------|-----------------
@@ -263,20 +263,108 @@ Business Unit | Multiple Choice | Get From CSC Differs For Clients
 Notification Email(s) Comma Separated | String | N/A
 CN DCV Email | String | N/A
 
-**CSC TrustedSecure Domain Validated UC Certificate - Details Tab**
+**CSC TrustedSecure DV, Multiple Names - Details Tab**
 
 CONFIG ELEMENT				| DESCRIPTION
 ----------------------------|------------------
-Template Short Name	| CSC TrustedSecure Domain Validated UC Certificate
-Template Display Name	| CSC TrustedSecure Domain Validated UC Certificate
-Friendly Name	| CSC TrustedSecure Domain Validated UC Certificate
+Template Short Name	| CSC TrustedSecure DV, Multiple Names
+Template Display Name	| CSC TrustedSecure DV, Multiple Names
+Friendly Name	| CSC TrustedSecure DV, Multiple Names
 Keys Size  | 2048
 Enforce RFC 2818 Compliance | True
 CSR Enrollment | True
 Pfx Enrollment | True
 
 
-**CSC TrustedSecure Domain Validated UC Certificate - Enrollment Fields**
+**CSC TrustedSecure DV, Multiple Names - Enrollment Fields**
+
+NAME | DATA TYPE	| VALUES
+-----|--------------|-----------------
+Term | Multiple Choice | 12,24
+Applicant First Name | String | N/A
+Applicant Last Name | String | N/A
+Applicant Email Address | String | N/A
+Applicant Phone | String | N/A
+Domain Control Validation Method | Multiple Choice | EMAIL
+Organization Contact | Multiple Choice | Get From CSC Differs For Clients
+Business Unit | Multiple Choice | Get From CSC Differs For Clients
+Notification Email(s) Comma Separated | String | N/A
+CN DCV Email | String | N/A
+Addtl Sans Comma Separated DCV Emails | String | N/A
+
+**CSC TrustedSecure EV, Multiple Names - Details Tab**
+
+CONFIG ELEMENT				| DESCRIPTION
+----------------------------|------------------
+Template Short Name	| CSC TrustedSecure EV, Multiple Names
+Template Display Name	| CSC TrustedSecure EV, Multiple Names
+Friendly Name	| CSC TrustedSecure EV, Multiple Names
+Keys Size  | 2048
+Enforce RFC 2818 Compliance | True
+CSR Enrollment | True
+Pfx Enrollment | True
+
+
+**CSC TrustedSecure EV, Multiple Names - Enrollment Fields**
+
+NAME | DATA TYPE	| VALUES
+-----|--------------|-----------------
+Term | Multiple Choice | 12,24
+Applicant First Name | String | N/A
+Applicant Last Name | String | N/A
+Applicant Email Address | String | N/A
+Applicant Phone | String | N/A
+Domain Control Validation Method | Multiple Choice | EMAIL
+Organization Contact | Multiple Choice | Get From CSC Differs For Clients
+Business Unit | Multiple Choice | Get From CSC Differs For Clients
+Notification Email(s) Comma Separated | String | N/A
+CN DCV Email | String | N/A
+Addtl Sans Comma Separated DCV Emails | String | N/A
+Organization Country | String | N/A
+
+**CSC TrustedSecure OV Wildcard, Multiple Names - Details Tab**
+
+CONFIG ELEMENT				| DESCRIPTION
+----------------------------|------------------
+Template Short Name	| CSC TrustedSecure OV Wildcard, Multiple Names
+Template Display Name	| CSC TrustedSecure OV Wildcard, Multiple Names
+Friendly Name	| CSC TrustedSecure OV Wildcard, Multiple Names
+Keys Size  | 2048
+Enforce RFC 2818 Compliance | True
+CSR Enrollment | True
+Pfx Enrollment | True
+
+
+**CSC TrustedSecure OV Wildcard, Multiple Names - Enrollment Fields**
+
+NAME | DATA TYPE	| VALUES
+-----|--------------|-----------------
+Term | Multiple Choice | 12,24
+Applicant First Name | String | N/A
+Applicant Last Name | String | N/A
+Applicant Email Address | String | N/A
+Applicant Phone | String | N/A
+Domain Control Validation Method | Multiple Choice | EMAIL
+Organization Contact | Multiple Choice | Get From CSC Differs For Clients
+Business Unit | Multiple Choice | Get From CSC Differs For Clients
+Notification Email(s) Comma Separated | String | N/A
+CN DCV Email | String | N/A
+Addtl Sans Comma Separated DCV Emails | String | N/A
+
+**CSC TrustedSecure DV Wildcard, Multiple Names - Details Tab**
+
+CONFIG ELEMENT				| DESCRIPTION
+----------------------------|------------------
+Template Short Name	| CSC TrustedSecure DV Wildcard, Multiple Names
+Template Display Name	| CSC TrustedSecure DV Wildcard, Multiple Names
+Friendly Name	| CSC TrustedSecure DV Wildcard, Multiple Names
+Keys Size  | 2048
+Enforce RFC 2818 Compliance | True
+CSR Enrollment | True
+Pfx Enrollment | True
+
+
+**CSC TrustedSecure DV Wildcard, Multiple Names - Enrollment Fields**
 
 NAME | DATA TYPE	| VALUES
 -----|--------------|-----------------

cscglobal-caplugin.Tests/CSCGlobalCAPlugin.Tests.csproj

@@ -0,0 +1,25 @@
+<Project Sdk="Microsoft.NET.Sdk">
+
+	<PropertyGroup>
+		<TargetFramework>net10.0</TargetFramework>
+		<ImplicitUsings>enable</ImplicitUsings>
+		<Nullable>enable</Nullable>
+		<IsPackable>false</IsPackable>
+		<IsTestProject>true</IsTestProject>
+		<AssemblyName>CSCGlobalCAPlugin.Tests</AssemblyName>
+		<RootNamespace>CscGlobalCAPluginTests</RootNamespace>
+	</PropertyGroup>
+
+	<ItemGroup>
+		<PackageReference Include="Microsoft.NET.Test.Sdk" Version="17.11.1" />
+		<PackageReference Include="Moq" Version="4.20.72" />
+		<PackageReference Include="xunit" Version="2.9.2" />
+		<PackageReference Include="xunit.runner.visualstudio" Version="2.8.2" />
+		<PackageReference Include="coverlet.collector" Version="6.0.2" />
+	</ItemGroup>
+
+	<ItemGroup>
+		<ProjectReference Include="..\cscglobal-caplugin\CSCGlobalCAPlugin.csproj" />
+	</ItemGroup>
+
+</Project>