(janitor/dependencies) Remove unused vaul dependency from apps/web - #6039
Open
kilo-code-bot[bot] wants to merge 1 commit into
Open
(janitor/dependencies) Remove unused vaul dependency from apps/web#6039kilo-code-bot[bot] wants to merge 1 commit into
kilo-code-bot[bot] wants to merge 1 commit into
Conversation
vaul (the shadcn drawer library) has no remaining consumers in apps/web. The last usages were removed in #4375 ("consolidate overlay components"), which dropped every `import { Drawer } from 'vaul'` but left the dependency declared in apps/web/package.json. Verified with repo-wide grep (imports, requires, dynamic imports, type references, CSS @import, and config/script references) and knip; the only remaining matches are unrelated "vault" strings. vaul remains in the lockfile as a transitive dependency of @expo/ui (apps/mobile), so this only drops apps/web's direct entry.
Contributor
Author
Code Review SummaryStatus: No Issues Found | Recommendation: Merge Files Reviewed (2 files)
Reviewed by grok-4.6 · Input: 75.5K · Output: 4.6K · Cached: 147.7K Review guidance: REVIEW.md from base branch |
pandemicsyn
approved these changes
Sep 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Removes the unused
vaulruntime dependency fromapps/web.Dependencies removed
vaul(1.1.2) fromapps/web/package.json(dependencies)Evidence that it was unused
requirecalls, dynamic imports, or type references tovaulin anyapps/websource file. The only remaining matches are unrelated strings containing "vault" (e.g. 1Password "vault" copy).import { Drawer } from 'vaul'but left the dependency declared inapps/web/package.json.knipflaggedvaulas an unused dependency ofapps/web/package.json; after removal it no longer appears.Dynamic, configuration, and tooling references checked
import('vaul')/require('vaul')/ subpath (vaul/...) references.next.config.*,tsconfig*.json, jest/vitest/playwright configs, or any package script..github/dependabot.ymlignore list.pnpm-workspace.yaml(catalog, overrides, packageExtensions, patchedDependencies).@importof the package (unlike the@fontsource-variable/*fonts, which knip also flags but which are legitimately imported viastyle.css).Package publication and peer-dependency considerations
apps/webis"private": trueand is not published, so there is no published-package contract or peer-dependency surface to preserve.vaulremains inpnpm-lock.yamlas a transitive dependency of@expo/ui@57.0.12(used byapps/mobile), so no other workspace is affected. Removing it only dropsapps/web's direct entry.Validation performed
pnpm install(lockfile regenerated) — succeeded; lockfile diff is minimal (3 removed lines in theapps/webimporter, 1optional: truemetadata change on a now-optionalvaulsnapshot).pnpm --filter web typecheck— passed (tsgo --noEmit).pnpm --filter web lint— passed (0 warnings, 0 errors).pnpm --filter web knip—vaulno longer reported as unused.pnpm install --frozen-lockfile --offline— succeeded (lockfile/manifest consistency confirmed;prepareandpostinstallscripts ran successfully).Not run (environment constraints)
apps/webtest(Jest) requires a reachable PostgreSQL database; PostgreSQL cannot be started in this environment.apps/webbuild(next build) requires deployment environment variables and is not run here.Uncertainty
None material:
vaulhas no source-level consumer of any kind inapps/web. The only nuance is thatvaulis retained in the lockfile via@expo/ui, which is expected and unaffected.