(janitor/dedupe): consolidate web sandboxIdFromUserId onto worker-utils - #6070
Open
kilo-code-bot[bot] wants to merge 1 commit into
Open
(janitor/dedupe): consolidate web sandboxIdFromUserId onto worker-utils#6070kilo-code-bot[bot] wants to merge 1 commit into
kilo-code-bot[bot] wants to merge 1 commit into
Conversation
apps/web re-declared sandboxIdFromUserId and inlined isValidInstanceId / sandboxIdFromInstanceId with comments saying they "must stay in sync" with @kilocode/worker-utils. The canonical implementation already lives in @kilocode/worker-utils/sandbox-id (and /instance-id), and web already imports that package's subpaths elsewhere. Delete the duplicate and point the single test consumer at the canonical module. Co-authored-by: kiloconnect[bot] <240665456+kiloconnect[bot]@users.noreply.github.com>
Contributor
Author
Code Review SummaryStatus: No Issues Found | Recommendation: Merge Files Reviewed (2 files)
No remaining consumers of the deleted module ( Reviewed by deepseek-v4.1-flash · Input: 0 · Output: 0 · Cached: 0 Review guidance: REVIEW.md from base branch |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
apps/web/src/lib/kiloclaw/sandbox-id.tsre-declaredsandboxIdFromUserIdand inlinedisValidInstanceId/sandboxIdFromInstanceId, with comments stating they "must stay in sync" with@kilocode/worker-utils.The canonical implementation already lives in
@kilocode/worker-utils/sandbox-id(re-exporting from./instance-id), andapps/webalready imports that package's subpaths elsewhere (e.g.@kilocode/worker-utils/hostname-label,@kilocode/worker-utils/instance-id). The stale "Next.js moduleResolution can't resolve the worker-utils subpath export" comment was no longer accurate.This deletes the 52-line duplicate and points the single consumer (a test) at the canonical module.
Changes
apps/web/src/lib/kiloclaw/sandbox-id.tsapps/web/src/routers/kiloclaw-billing-router.test.ts: importsandboxIdFromUserIdfrom@kilocode/worker-utils/sandbox-idVerification
tsgo --noEmit -p apps/web/tsconfig.json— passoxlinton the changed test file — 0 warnings / 0 errorsgit diff --check— cleanPostgres/Redis-backed tests could not be run in this environment.