(janitor/dependencies): remove unused vaul dependency from web - #6071
Open
kilo-code-bot[bot] wants to merge 1 commit into
Open
(janitor/dependencies): remove unused vaul dependency from web#6071kilo-code-bot[bot] wants to merge 1 commit into
kilo-code-bot[bot] wants to merge 1 commit into
Conversation
Contributor
Author
Code Review SummaryStatus: No Issues Found | Recommendation: Merge Executive SummaryVerified at HEAD Files Reviewed (2 files)
Verification Notes
Reviewed by deepseek-v4.1-flash · Input: 0 · Output: 0 · Cached: 0 Review guidance: REVIEW.md from base branch |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Dependencies removed
vaul@1.1.2(removed fromapps/webdependencies)Evidence that each was unused
vaulis the shadcn-style drawer/sheet component library. It was declared as adirect dependency of
apps/webbut has no consumer anywhere in that package:import ... from "vaul",require("vaul"), or dynamicimport("vaul")anywhere in
apps/web/src,scripts/, or test files. A repo-wide search forthe
vaulidentifier only matched unrelated "vault" substrings (1Passwordvault copy) and the
@expo/uitransitive dependency inapps/mobile.knip(already configured inapps/web) reportsvaulunder "Unuseddependencies" pointing at
apps/web/package.json:174.Dynamic, configuration, and tooling references checked
apps/web(searched
*.ts,*.tsx,*.js,*.mjs,*.jsx).apps/webscript invokesvaul.next.config.mjs,postcss.config.mjs,jest.config.ts,sentry.*.config.ts,playwright*.config.ts, Tailwind config, or any CSS@plugin/@import.vaulis a Reactcomponent library imported explicitly, not a side-effectful or
convention-discovered package.
Package publication and peer-dependency considerations
apps/webis"private": trueand is not published, so removing a directdependency cannot break a published-package contract.
vaulhas only peer dependencies (react,react-dom), which are alreadydeclared separately in
apps/web.vaulis not removed from the monorepo lockfile:@expo/ui@57.0.17(usedby
apps/mobile) depends onvaul, so thevaulsnapshot and its@expo/uireference remain inpnpm-lock.yaml. Only theapps/webimporterentry is dropped.
Validation performed
pnpm install --lockfile-only --frozen-lockfilepasses (lockfile isconsistent with the edited
package.json).pnpm --filter web lintpasses (0 warnings, 0 errors).pnpm --filter web typecheckpasses.git diff --checkclean.vaulimporter entry removed; nounrelated changes.
Uncertainty
pnpm --filter web testwas not run: the test suite requiresPostgreSQL/Redis, which cannot be started in this resource-constrained
environment. Since no source files changed (dependency removal only) and
typecheck/lint passed, this is low-risk, but it is documented here for
completeness.
pnpm install --no-frozen-lockfilerun in this environmentre-resolved unrelated peer dependencies (e.g.
@types/noderesolution andStorybook peer-dep sets) and OOM'd once. The final lockfile edit was therefore
applied by hand and verified with
--frozen-lockfilerather than trusting thatinstall run.