Skip to content

Remove StepFun 3.7 Flash from Auto Free - #6077

Open
chrarnoldus wants to merge 8 commits into
mainfrom
fix/remove-stepfun-from-auto-free
Open

Remove StepFun 3.7 Flash from Auto Free#6077
chrarnoldus wants to merge 8 commits into
mainfrom
fix/remove-stepfun-from-auto-free

Conversation

@chrarnoldus

@chrarnoldus chrarnoldus commented Sep 11, 2026

Copy link
Copy Markdown
Contributor

Summary

  • remove stepfun/step-3.7-flash:free from the Auto Free routing pool
  • keep the model public in the catalog
  • update Auto Free membership expectations

Testing

  • not run locally; CI will validate the change

Co-authored-by: kiloconnect[bot] <240665456+kiloconnect[bot]@users.noreply.github.com>
@chrarnoldus chrarnoldus self-assigned this Sep 11, 2026
Comment thread apps/web/src/lib/ai-gateway/models.ts
@kilo-code-bot

kilo-code-bot Bot commented Sep 11, 2026

Copy link
Copy Markdown
Contributor

Code Review Summary

Status: No Issues Found | Recommendation: Merge

Executive Summary

The incremental commit spreads the real gateway-models-cache exports into the module mock in resolution.test.ts while still overriding getOpenRouterModelsFromDatabase; the test-only change is correct, and the previously reported Auto Free fixture breakage is confirmed fixed. No new defect found in the changed lines.

Files Reviewed (1 file)
  • apps/web/src/lib/ai-gateway/auto-model/resolution.test.ts
Previous Review Summaries (7 snapshots, latest commit f7fa041)

Current summary above is authoritative. Previous snapshots are kept for context only.

Previous review (commit f7fa041)

Status: No Issues Found | Recommendation: Merge

Executive Summary

The incremental commit only switches resolution.test.ts to load the resolver via jest.requireActual after a type-only import; the changed lines mirror an existing repo pattern, keep the catalog mock in effect, and the previously reported Auto Free fixture breakage remains fixed. No new defect found in the changed lines.

Files Reviewed (1 file)
  • apps/web/src/lib/ai-gateway/auto-model/resolution.test.ts

Previous review (commit b1ad96a)

Status: No Issues Found | Recommendation: Merge

Executive Summary

The incremental commit only replaces an inline import() type in resolution.test.ts with a type-only namespace import (import type * as GatewayModelsCache) referenced via jest.Mocked<typeof GatewayModelsCache>; this matches an existing repo pattern, is erased at runtime, and the previously reported Auto Free fixture breakage is confirmed fixed. No new defect found in the changed lines.

Files Reviewed (1 file)
  • apps/web/src/lib/ai-gateway/auto-model/resolution.test.ts

Previous review (commit 1a9669d)

Status: No Issues Found | Recommendation: Merge

Executive Summary

The incremental commit only changes how resolution.test.ts retrieves the mocked getOpenRouterModelsFromDatabase (now via jest.requireMock, an existing repo pattern); the mock target, setup, and assertions are unchanged and no new defect was found.

Files Reviewed (1 file)
  • apps/web/src/lib/ai-gateway/auto-model/resolution.test.ts

Previous review (commit 95b3c8a)

Status: No Issues Found | Recommendation: Merge

Executive Summary

The latest incremental commit only rejoins two Auto Free assertions onto single lines in route.test.ts; it is a formatting-only change with no functional effect or new defect.

Files Reviewed (1 file)
  • apps/web/src/app/api/openrouter/[...path]/route.test.ts

Previous review (commit d0c2472)

Status: No Issues Found | Recommendation: Merge

Executive Summary

The two incremental commits only retarget Auto Free test fixtures from StepFun to poolside/laguna-s-2.1:free and move the mocked OpenRouter model set into a scoped beforeEach; no new defects found in the changed lines.

Files Reviewed (2 files)
  • apps/web/src/app/api/openrouter/[...path]/route.test.ts
  • apps/web/src/lib/ai-gateway/auto-model/resolution.test.ts

Previous review (commit 9fe21ea)

Status: No Issues Found | Recommendation: Merge

Files Reviewed (3 files)
  • apps/web/src/lib/ai-gateway/auto-model/resolution.test.ts
  • apps/web/src/lib/ai-gateway/models.ts
  • apps/web/src/lib/ai-gateway/models.test.ts

Previous review (commit ba443bd)

Status: 1 Issue Found | Recommendation: Address before merge

Executive Summary

Removing stepfun/step-3.7-flash:free from autoFreeModels leaves the existing resolution.test.ts Auto Free test asserting StepFun is the resolvable candidate, so CI will fail.

Overview

Severity Count
CRITICAL 1
WARNING 0
SUGGESTION 0
Issue Details (click to expand)

CRITICAL

File Line Issue
apps/web/src/lib/ai-gateway/models.ts 41 Removing StepFun from autoFreeModels breaks resolution.test.ts:409 (excludes candidates denied by the effective organization policy), which expects getAutoFreeCandidates to yield StepFun and resolve to it. With the mocked empty OpenRouter cache, candidates become empty and the code returns no_free_models_available, so the test must be updated.
Files Reviewed (2 files)
  • apps/web/src/lib/ai-gateway/models.ts - 1 issue
  • apps/web/src/lib/ai-gateway/models.test.ts - 0 issues

Fix these issues in Kilo Cloud


Reviewed by deepseek-v4.1-flash · Input: 0 · Output: 0 · Cached: 0

Review guidance: REVIEW.md from base branch main

chrarnoldus and others added 7 commits September 11, 2026 10:29
Co-authored-by: kiloconnect[bot] <240665456+kiloconnect[bot]@users.noreply.github.com>
Co-authored-by: kiloconnect[bot] <240665456+kiloconnect[bot]@users.noreply.github.com>
Co-authored-by: kiloconnect[bot] <240665456+kiloconnect[bot]@users.noreply.github.com>
Co-authored-by: kiloconnect[bot] <240665456+kiloconnect[bot]@users.noreply.github.com>
Co-authored-by: kiloconnect[bot] <240665456+kiloconnect[bot]@users.noreply.github.com>
Co-authored-by: kiloconnect[bot] <240665456+kiloconnect[bot]@users.noreply.github.com>
Co-authored-by: kiloconnect[bot] <240665456+kiloconnect[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant