Skip to content

Revert per-repo changes - #6286

Open
intentionally-left-nil wants to merge 3 commits into
mainfrom
remove-per-repo
Open

intentionally-left-nil wants to merge 3 commits into
mainfrom
remove-per-repo

Conversation

@intentionally-left-nil

Copy link
Copy Markdown
Contributor

Instead of having a single UI for all per-repo changes, we are going to leave the existing code alone for now. There already is the ability to turn code reviewers off per-repo

and a bigger feature ended up having too much scope creep

Comment thread packages/db/src/migrations/0250_drop_repository_customizations.sql Outdated
Comment thread packages/db/src/migrations/0250_drop_repository_customizations.sql Outdated
@kilo-code-bot

kilo-code-bot Bot commented Sep 17, 2026

Copy link
Copy Markdown
Contributor

Code Review Summary

Status: 1 Issue Found | Recommendation: Address before merge

Overview

Severity Count
CRITICAL 0
WARNING 1
SUGGESTION 0
Issue Details (click to expand)

WARNING

File Line Issue
apps/web/src/lib/integrations/platforms/github/webhook-handlers/pull-request-handler.ts 300 Removing the per-repo pr_review_mode guard (step 5b) means repositories or installations explicitly configured with automated PR reviews off now receive reviews. selected_repository_ids is only honored when repository_selection_mode is selected, so it is not an equivalent off-switch for the default all mode.
Files Reviewed (24 files)
  • ENVIRONMENT.md - clean
  • apps/web/src/app/cloud-agent-fork/review/[reviewId]/route.ts + test - clean
  • apps/web/src/components/integrations/GitHubIntegrationDetails.tsx - clean
  • apps/web/src/components/integrations/GitHubRepositoryCustomizationsPreview.tsx + test - deleted
  • apps/web/src/components/integrations/IntegrationDetailPage.tsx - clean
  • apps/web/src/components/integrations/OrganizationGitHubInstallations.tsx - clean
  • apps/web/src/lib/bot/tools/spawn-cloud-agent-session.ts + test - clean
  • apps/web/src/lib/config.server.ts - clean
  • apps/web/src/lib/integrations/core/types.ts + test - clean
  • apps/web/src/lib/integrations/db/platform-integrations.ts + test - clean
  • apps/web/src/lib/integrations/github-apps-service.ts + test - clean
  • apps/web/src/lib/integrations/github-repository-settings.ts + test - deleted
  • apps/web/src/lib/integrations/platforms/github/webhook-handlers/pull-request-handler.ts + test - 1 issue
  • apps/web/src/routers/github-apps-router.ts + test - clean
  • services/kilo-mcp/catalog.json - generated, clean

Fix these issues in Kilo Cloud

Previous Review Summaries (2 snapshots, latest commit 582517d)

Current summary above is authoritative. Previous snapshots are kept for context only.

Previous review (commit 582517d)

Status: 1 Issue Found | Recommendation: Address before merge

Executive Summary

The only change since the previous review is an import reformatting in github-apps-service.test.ts; the previously reported non-retryable DROP TABLE migration remains unresolved and still runs before the still-serving revision is promoted.

Overview

Severity Count
CRITICAL 0
WARNING 1
SUGGESTION 0
Issue Details (click to expand)

WARNING

File Line Issue
packages/db/src/migrations/0250_drop_repository_customizations.sql 1 Plain DROP TABLE has no IF EXISTS, so it is not retryable (same failure mode patched for 0204 in #5037). run-migrations also completes before promote-app, so the still-serving revision queries repository_customizations on every pull_request webhook until promotion.
Incremental Changes (1 file)
  • apps/web/src/lib/integrations/github-apps-service.test.ts - import consolidated onto one line; clean, no new findings
Files Reviewed (29 files)
  • ENVIRONMENT.md - clean
  • apps/web/src/app/cloud-agent-fork/review/[reviewId]/route.ts + test - clean
  • apps/web/src/components/integrations/GitHubIntegrationDetails.tsx - clean
  • apps/web/src/components/integrations/GitHubRepositoryCustomizationsPreview.tsx + test - deleted
  • apps/web/src/components/integrations/IntegrationDetailPage.tsx - clean
  • apps/web/src/components/integrations/OrganizationGitHubInstallations.tsx - clean
  • apps/web/src/lib/bot/tools/spawn-cloud-agent-session.ts + test - clean
  • apps/web/src/lib/config.server.ts - clean
  • apps/web/src/lib/integrations/core/types.ts + test - clean
  • apps/web/src/lib/integrations/db/platform-integrations.ts + test - clean
  • apps/web/src/lib/integrations/github-apps-service.ts + test - clean
  • apps/web/src/lib/integrations/github-repository-settings.ts + test - deleted
  • apps/web/src/lib/integrations/platforms/github/webhook-handlers/pull-request-handler.ts + test - clean
  • apps/web/src/routers/github-apps-router.ts + test - clean
  • packages/db/src/migrations/0250_drop_repository_customizations.sql - 1 issue
  • packages/db/src/migrations/meta/0250_snapshot.json, meta/_journal.json - generated, consistent
  • packages/db/src/schema.ts, schema-types.ts, schema.test.ts - clean
  • services/kilo-mcp/catalog.json - generated, clean

Fix these issues in Kilo Cloud

Previous review (commit a483752)

Status: 1 Issue Found | Recommendation: Address before merge

Executive Summary

The revert itself is complete and self-consistent (no dangling references to the removed feature), but the new DROP TABLE migration is non-retryable and runs while the previously-deployed revision still reads that table.

Overview

Severity Count
CRITICAL 0
WARNING 1
SUGGESTION 0
Issue Details (click to expand)

WARNING

File Line Issue
packages/db/src/migrations/0250_drop_repository_customizations.sql 1 Plain DROP TABLE has no IF EXISTS, so it is not retryable (same failure mode patched for 0204 in #5037). run-migrations also completes before promote-app, so the still-serving revision queries repository_customizations on every pull_request webhook until promotion.
Files Reviewed (29 files)
  • ENVIRONMENT.md - clean
  • apps/web/src/app/cloud-agent-fork/review/[reviewId]/route.ts + test - clean
  • apps/web/src/components/integrations/GitHubIntegrationDetails.tsx - clean
  • apps/web/src/components/integrations/GitHubRepositoryCustomizationsPreview.tsx + test - deleted
  • apps/web/src/components/integrations/IntegrationDetailPage.tsx - clean
  • apps/web/src/components/integrations/OrganizationGitHubInstallations.tsx - clean
  • apps/web/src/lib/bot/tools/spawn-cloud-agent-session.ts + test - clean
  • apps/web/src/lib/config.server.ts - clean
  • apps/web/src/lib/integrations/core/types.ts + test - clean
  • apps/web/src/lib/integrations/db/platform-integrations.ts + test - clean
  • apps/web/src/lib/integrations/github-apps-service.ts + test - clean
  • apps/web/src/lib/integrations/github-repository-settings.ts + test - deleted
  • apps/web/src/lib/integrations/platforms/github/webhook-handlers/pull-request-handler.ts + test - clean
  • apps/web/src/routers/github-apps-router.ts + test - clean
  • packages/db/src/migrations/0250_drop_repository_customizations.sql - 1 issue
  • packages/db/src/migrations/meta/0250_snapshot.json, meta/_journal.json - generated, consistent (prevId matches 0249, table removed)
  • packages/db/src/schema.ts, schema-types.ts, schema.test.ts - clean
  • services/kilo-mcp/catalog.json - generated, clean

Fix these issues in Kilo Cloud


Reviewed by deepseek-v4.1-flash · Input: 0 · Output: 0 · Cached: 0

Review guidance: REVIEW.md from base branch main

@pandemicsyn pandemicsyn left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pre-approving but might be worth breaking up this change like the bot says. Since we do canary rollouts the migration will land first and we'll have a window of time where both versions are live.

Comment thread packages/db/src/migrations/0250_drop_repository_customizations.sql Outdated
Instead of having a single UI for all per-repo changes, we are
going to leave the existing code alone for now. There already
is the ability to turn code reviewers off per-repo

and a bigger feature ended up having too much scope creep
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants