fix(mobile): drop Latin uppercase letter-spacing from RTL section labels - #6435
Conversation
|
This description names a scenario the proof did not capture:
A repeated proof run rebuilds the same evidence, so no proof run is dispatched for a named gap. Merging with this gap open is your decision. |
Code Review SummaryStatus: No Issues Found | Recommendation: Merge Executive SummaryThe incremental commit adds env-file discovery to Files Reviewed (2 files)
Previous Review Summaries (2 snapshots, latest commit afd0088)Current summary above is authoritative. Previous snapshots are kept for context only. Previous review (commit afd0088)Status: 1 Issue Found | Recommendation: Address before merge Executive SummaryThe incremental change exports Overview
Issue Details (click to expand)SUGGESTION
Files Reviewed (8 files)
Fix these issues in Kilo Cloud Previous review (commit 57ce7b8)Status: No Issues Found | Recommendation: Merge Executive SummaryReviewed the RTL-aware eyebrow/section-label styling change across Files Reviewed (5 files)
Reviewed by deepseek-v4.1-flash · Input: 0 · Output: 0 · Cached: 0 Review guidance: REVIEW.md from base branch |
57ce7b8 to
afd0088
Compare
afd0088 to
d3abaf7
Compare
|
The merge bot leaves this one to a human: Jev reads it as a human's merge (confidence 0.98); destructive or config change (p=0.56). |
|
The merge bot leaves this one to a human: Jev reads it as a human's merge (confidence 0.98); destructive or config change (p=0.56). |
|
The merge bot leaves this one to a human: destructive or config change (p=0.62). |
Changelog for users
Changelog for maintainers
eyebrowtext variant no longer hard-codesuppercase tracking-[1.5px];Textadds those classes only outside RTL.SectionHeaderimports the sharedEYEBROW_LATIN_DISPLAYstring, so both eyebrow-scale labels stay identical; its family, size, color, and alignment are unchanged.hasPaymentMethodInStripetreats Stripe's "No such customer" as no payment method on file and still rethrows every other failure;safeDeleteStripeCustomershares the same predicate.stripe-client.test.tscovers the present, absent, unknown-customer, and unexpected-error cases for both helpers.playwright.setup-smoke.config.tsderives its base URL from theAPP_URL_OVERRIDEorigin whenPLAYWRIGHT_BASE_URLis unset; an explicitPLAYWRIGHT_BASE_URLstill wins.E2E proof
E2E proof — log excerpts