fix(mobile): offer every recent repository in the Agents session filter - #6458
Merged
Merged
Conversation
Surface: the mobile app (apps/mobile). Title: fix(mobile): offer every recent repository in the Agents session filter ## Problem The Agents session filter modal cannot filter by repositories beyond the three most recent ones. `apps/mobile/src/components/agents/use-agent-session-list-data.ts:130-147` builds the modal's project options from `recentRepositories?.repositories.slice(0, 3) ?? []`, then adds only the currently selected `projectFilter` values. The backing procedure returns up to ten repositories (`apps/web/src/routers/cli-sessions-v2-router.ts:1297-1306` selects with `LIMIT 10`), so entries 4-10 are dropped by the client. `apps/mobile/src/components/agents/platform-filter-modal.tsx:102-108,163-179` renders exactly those options (plus selected values), and both the Agents tab and the session-history screen pass this `projectOptions`, so there is no other way to add a project filter. A user with four or more recently used repositories cannot filter sessions or search results down to the older ones. This is a filtering/relevance defect in the session list, not a cosmetic one: the dropped rows are unreachable controls, not just hidden text. ## Requested behaviour The session filter must offer a project row for every repository the `cliSessionsV2.recentRepositories` query returns (up to the server's own limit), not only the first three, while keeping: - the currently selected project values merged in even when they are absent from the recent list (existing behavio
Contributor
Code Review SummaryStatus: No Issues Found | Recommendation: Merge Executive SummaryThe session-history filter now offers every repository the server returns (up to its Files Reviewed (4 files)
Verification Notes
Reviewed by deepseek-v4.1-flash · Input: 0 · Output: 0 · Cached: 0 Review guidance: REVIEW.md from base branch |
Collaborator
Author
|
This description names a scenario the proof did not capture:
A repeated proof run rebuilds the same evidence, so no proof run is dispatched for a named gap. Merging with this gap open is your decision. |
eshurakov
approved these changes
Sep 21, 2026
eshurakov
left a comment
Contributor
There was a problem hiding this comment.
Approved after a shallow triage pass. No blocking findings.
iscekic
deleted the
kwf/janitor-2026-09-21-features-and-workflows-9807
branch
September 21, 2026 15:26
This was referenced Sep 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog for users
Changelog for maintainers
use-agent-session-list-data.ts: removed the client-side.slice(0, 3)cap; thecliSessionsV2.recentRepositoriesprocedure already bounds the list withLIMIT 10.projectFiltervalues absent from the recent list are still merged in and deduplicated bygitUrl.platform-filter-modal.tsx: the sheet content gainsmax-h-[80%]and its singleScrollViewgainsshrink, so extra rows scroll instead of clipping.projectOptionsmemo is the only product behavior change to review.E2E proof
[e1] Open Agents → filter sheet lists one checkbox row per recent repository, no duplicates — Sheet rendered 10 PROJECT checkbox rows, distinct=10 total=10 with no duplicate gitUrl, matching the 10 rows the query returns out of 12 recent repositories (e1-rows.log, e1-repos.log); captures e1.png/e1b.png.
[e1] Open Agents → filter sheet lists one checkbox row per recent repository, no duplicates — e2e-cli/e1b.png (capture not retained)
[e4] Selected project row for a repository no longer recent still renders and toggles off and on — After golf-service was aged out of the recent window (e4-aged.log) and the app was relaunched, the reopened sheet rendered iscekic/golf-service checked="true" as the last row, then checked="false" with the row kept after a tap, then re-applied and narrowed the list (e4.log); captures e4e.png/e4f.png/e4g.png.
[e4] Selected project row for a repository no longer recent still renders and toggles off and on — e2e-cli/e4g.png (capture not retained)
[e1] Open Agents → filter sheet lists one checkbox row per recent repository, no duplicates
[e4] Selected project row for a repository no longer recent still renders and toggles off and on
E2E proof — log excerpts
/home/igor_kilocode_ai/.local/share/kwf/sections/janitor-2026-09-21-features-and-workflows-9807/e2e-cli/e1-rows.log/home/igor_kilocode_ai/.local/share/kwf/sections/janitor-2026-09-21-features-and-workflows-9807/e2e-cli/e1-repos.log/home/igor_kilocode_ai/.local/share/kwf/sections/janitor-2026-09-21-features-and-workflows-9807/e2e-cli/e4.log/home/igor_kilocode_ai/.local/share/kwf/sections/janitor-2026-09-21-features-and-workflows-9807/e2e-cli/e4-aged.log/home/igor_kilocode_ai/.local/share/kwf/sections/janitor-2026-09-21-features-and-workflows-9807/e2e-cli/cli-tests.log/home/igor_kilocode_ai/.local/share/kwf/sections/janitor-2026-09-21-features-and-workflows-9807/e2e-mobile-app/e1-applied.txt/home/igor_kilocode_ai/.local/share/kwf/sections/janitor-2026-09-21-features-and-workflows-9807/e2e-mobile-app/e1-reopen.txt/home/igor_kilocode_ai/.local/share/kwf/sections/janitor-2026-09-21-features-and-workflows-9807/e2e-mobile-app/e1-restart.txt/home/igor_kilocode_ai/.local/share/kwf/sections/janitor-2026-09-21-features-and-workflows-9807/e2e-mobile-app/e2-scrolled.txt/home/igor_kilocode_ai/.local/share/kwf/sections/janitor-2026-09-21-features-and-workflows-9807/e2e-mobile-app/e2-run.log/home/igor_kilocode_ai/.local/share/kwf/sections/janitor-2026-09-21-features-and-workflows-9807/e2e-web/web-e2e.logOwner request
Follow-ups (not changed here)