Conversation
Contributor
Code Review SummaryStatus: No Issues Found | Recommendation: Merge Executive SummaryThe keyboard clearance and measured-band changes are sound: Files Reviewed (10 files)
Previous Review Summary (commit d1191eb)Current summary above is authoritative. Previous snapshots are kept for context only. Previous review (commit d1191eb)Status: 2 Issues Found | Recommendation: Address before merge Overview
Issue Details (click to expand)WARNING
Files Reviewed (10 files)
Reviewed by deepseek-v4.1-flash · Input: 0 · Output: 0 · Cached: 0 Review guidance: REVIEW.md from base branch |
iscekic
marked this pull request as draft
September 21, 2026 08:22
iscekic
added a commit
that referenced
this pull request
Sep 21, 2026
iscekic
force-pushed
the
kwf/explorer-agents-search-empty-the-keyboard-accessory-bar-c-3488f-e8b6
branch
from
September 21, 2026 10:33
d936267 to
a49426e
Compare
iscekic
marked this pull request as ready for review
September 21, 2026 10:56
iscekic
marked this pull request as draft
September 21, 2026 15:58
iscekic
force-pushed
the
kwf/explorer-agents-search-empty-the-keyboard-accessory-bar-c-3488f-e8b6
branch
from
September 21, 2026 19:46
ca35465 to
e01d9df
Compare
iscekic
marked this pull request as ready for review
September 21, 2026 19:59
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog for users
Changelog for maintainers
apps/mobile/src/components/agents/session-list-screen.tsx:309— accepted:showFabnow also excludes the no-match body (!noMatchBody), so the FAB yields the band that state fills; the rows list keeps the FAB and clears it with its own frame inset, and the load-failure body keeps it as the only creation affordance while the list is failing.apps/mobile/src/components/empty-state.tsx:21— accepted: the fixedFULL_FORM_BANDconstant is gone; the compact form is chosen by comparing the band against the full form's own measured height, so Dynamic Type, wrapped copy, and the pull-to-refresh line cannot select a form the band overflows.tabBarHideOnKeyboard: truesits on the shared tabsscreenOptions, so every tab hides the bar while the IME is up; the bar keeps its absolute placement, so hiding it moves no surrounding layout and dismissal restores it in place.getCenteredStateBandcomputes the visible viewport clipped to the surface and reserved insets, andgetCenteredStateLayoutshares it so centering and compaction read the same numbers.CenteredStatepublishes the measured band throughCenteredStateBandContext(useCenteredStateBandlives in its own module so consumers resolve it when the component is mocked) and measures the pull-to-refresh line above its children, subtracting that height so a child compacts on the space it actually gets.CenteredEmptyStateContentkeeps the last measured full-form height, switches form during render, and blanks the form until the new form's own layout lands.E2E proof
Owner request
E2E proof — log excerpts
/home/igor_kilocode_ai/.local/share/kwf/sections/kwf-fix-review-4559/e2e-mobile-app/e2-scene.log/home/igor_kilocode_ai/.local/share/kwf/sections/kwf-fix-review-4559/e2e-mobile-app/e2-landscape.digest.log/home/igor_kilocode_ai/.local/share/kwf/sections/kwf-fix-review-4559/e2e-mobile-app/e2-nextjs-down.log/home/igor_kilocode_ai/.local/share/kwf/sections/kwf-fix-review-4559/e2e-mobile-app/e3-run.log