Reject bool for max_size and header limit args - #326
Closed
Pitchfork-and-Torch wants to merge 1 commit into
Closed
Pitchfork-and-Torch wants to merge 1 commit into
Pitchfork-and-Torch wants to merge 1 commit into
Conversation
bool is a numbers.Number and subclasses int, so max_size=True and max_header_count/max_header_size=True previously passed validation and silently became 1. Reject bool explicitly for these limits.
Merging this PR will not alter performance
Comparing Footnotes
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
boolis anumbers.Numberand subclassesint, so:max_size=Truepassed the existingisinstance(..., Number) and max_size >= 1check (sinceTrue >= 1) and silently became size 1max_header_count=True/max_header_size=Truehad no type checks and likewise became 1This change rejects
boolformax_sizeonOctetStreamParser,QuerystringParser, andMultipartParser, and adds int/non-bool validation formax_header_count/max_header_size.Test plan
max_size/ header tests pass