feat: automatización de publicación de promociones para tryonyou.pro - #25
Conversation
- Se agrega script en Python (`scripts/auto_deploy_v2.py`) para validar campos obligatorios (title, description, discount_code, valid_until) en el contenido JSON promocional y desplegarlo en la API de producción. - Se agrega wrapper en Bash (`scripts/auto_deploy_v2.sh`) con mensajes y control de errores en español. - Se incluyen pruebas unitarias en `tests/test_auto_deploy_v2.py` utilizando pytest y mock para simular las llamadas a la red. Co-authored-by: LVT-ENG <214667862+LVT-ENG@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
The initial commit failed CI due to python lint issues: - `scripts/auto_deploy_v2.py`: unsorted imports - `tests/test_auto_deploy_v2.py`: unsorted imports and unused import `urllib.error` This resolves the linting errors using `ruff check --fix`. Co-authored-by: LVT-ENG <214667862+LVT-ENG@users.noreply.github.com>
The initial fix applied ruff checking, but `pyright` checks (which are part of `rye run lint` in the CI) failed due to missing type annotations in the tests file. Added type hints to the pytest fixtures and variables, resolved Pyright warnings for unknown parameters and mocked objects, and removed unused imports in `tests/test_auto_deploy_v2.py`. This resolves the remaining type checking issues that failed the CI lint job. Co-authored-by: LVT-ENG <214667862+LVT-ENG@users.noreply.github.com>
1 participant
Automatización de la publicación de promociones para la plataforma tryonyou.pro. Este pull request introduce un sistema de validación y despliegue para contenido promocional a través de un script en Python y un wrapper en Bash. Asegura que los campos críticos del JSON estén presentes y gestiona el envío al entorno de producción de forma segura mediante la variable de entorno
TRYONYOU_API_KEY.PR created automatically by Jules for task 11212311599814603122 started by @LVT-ENG