-
Notifications
You must be signed in to change notification settings - Fork 5
feat(licenses): resolve requirements.txt pin licenses from PyPI and add --offline #113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When an Action user follows this description by setting
AISBOM_OFFLINE=1whileshare: trueis configured, the new CLI rejects the combination with exit 1, butaction/entrypoint.shonly propagatesSCAN_EXIT == 2and ultimately exits 0. The workflow therefore reports success despite producing no new SBOM; worse, if the configured output path already exists, the wrapper proceeds to comment on or upload that stale file. Handle the CLI's exit 1 in the Action wrapper before processing the output.Useful? React with 👍 / 👎.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed in 3d5b314.
action/entrypoint.shnow rejectsAISBOM_OFFLINEtogether withshare: truebefore the scan runs and exits 1, so the job fails and no pre-existingsbom.jsonis commented on or uploaded. Exit 1 is added to the entrypoint's documented exit codes. Tests cover the refused pair (no scan, no helper invocations, exit 1) and offline without share (scans normally). I kept this narrow on purpose: the wrapper not re-raising a CLI exit 1 in general (e.g. a missingdirectory) predates this PR, and changing it would flip the job result for existing users, so it is tracked separately.