Use centrally configured SchemaFactory - #7875
Merged
Merged
Conversation
labkey-adam
approved these changes
Jul 29, 2026
labkey-jeckels
added a commit
to LabKey/targetedms
that referenced
this pull request
Aug 8, 2026
## Rationale We should configure `SchemaFactory` centrally like other XML objects so that we get the right settings consistently. ## Related Pull Requests - LabKey/platform#7875 ## Changes - Use utility/factory method to get a configured `SchemaFactory` with external references disabled
labkey-jeckels
added a commit
to LabKey/server
that referenced
this pull request
Aug 8, 2026
## Rationale We want to avoid introducing new XXE problems in the future. ## Related Pull Requests - LabKey/platform#7875 ## Changes - IntelliJ warning to prevent use for future non-hardened SchemaFactories
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale
We should configure
SchemaFactorycentrally like other XML objects so that we get the right settings consistently.Changes
SchemaFactorywith external references disabledTasks 📍
Manual TestingTest Automation