test(frontend): add settings page ↔ useSettings desync regression tests - #1417
Open
BigMick03 wants to merge 2 commits into
Open
test(frontend): add settings page ↔ useSettings desync regression tests#1417BigMick03 wants to merge 2 commits into
BigMick03 wants to merge 2 commits into
Conversation
Add tests for the three-way theme/currency/format desync documented in Architecture #60. The settings page manages its own useState + direct localStorage writes, bypassing useSettings()'s shared singleton. An already-mounted useSettings() consumer never sees changes made on the settings page until a full page reload. - 10 passing tests lock in current broken behavior as baseline - 5 failing tests assert correct sync, providing concrete regression signal that will pass once #60 is fixed Generated with Codebuff 🤖 Co-Authored-By: Codebuff <noreply@codebuff.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add tests for the three-way theme/currency/format desync documented in Architecture #60. The settings page manages its own useState + direct localStorage writes, bypassing useSettings()'s shared singleton. An already-mounted useSettings() consumer never sees changes made on the settings page until a full page reload.
Closes #1289
Description
Type of Change
Related Issues
Closes #
Changes Made
Testing
Test Coverage
Test Steps
ClosesBreaking Changes
Breaking Changes:
Migration Guide:
Screenshots/Demo
Checklist
Additional Notes