refactor(ui): use a single-column detail popup - #767
Draft
tiankaima wants to merge 13 commits into
Draft
Conversation
Co-authored-by: Tiankai Ma <tiankaima.dev@gmail.com>
Deploying with
|
| Status | Name | Latest Commit | Updated (UTC) |
|---|---|---|---|
| ✅ Deployment successful! View logs |
life-ustc | feded7f | Aug 28 2026, 01:35 PM |
Contributor
|
E2E HTML report is ready: https://life-ustc.github.io/e2e-snapshot-artifacts/reports/33169004384/index.html |
Co-authored-by: Tiankai Ma <tiankaima.dev@gmail.com>
cursor
Bot
changed the title
Co-authored-by: Tiankai Ma <tiankaima.dev@gmail.com>
Co-authored-by: Tiankai Ma <tiankaima.dev@gmail.com>
cursor
Bot
changed the title
Co-authored-by: Tiankai Ma <tiankaima.dev@gmail.com>
cursor
Bot
changed the title
Keep page side rails on pages. Detail popups now use one scrollable reading column with the title in a sticky header and discussion full-width after the details, instead of a desktop two-column overlay. Co-authored-by: Tiankai Ma <tiankaima.dev@gmail.com>
cursor
Bot
changed the title
Co-authored-by: Tiankai Ma <tiankaima.dev@gmail.com>
Adopt main's shared homework detail dialog. Keep the icon-only close control and the single-column popup contracts, and drop the superseded dashboard-local dialog pieces. Co-authored-by: Tiankai Ma <tiankaima.dev@gmail.com>
cursor Bot
pushed a commit
that referenced
this pull request
Aug 28, 2026
GitHub cannot render Cursor-local artifact paths, so these PNGs are committed for inline before/after images in #767. Co-authored-by: Tiankai Ma <tiankaima.dev@gmail.com>
cursor
Bot
force-pushed
the
cursor/fix-dialog-close-ui-0da7
branch
from
August 28, 2026 11:10
9e48e96 to
0d7cb0c
Compare
Keep overlay cards as one reading column: datetime and relative urgency first, then compact status/tag chips. Move homework tags off the more-details trigger, and drop the status side column. Co-authored-by: Tiankai Ma <tiankaima.dev@gmail.com>
The dialog's sr-only description also includes the localized priority, so scanning the whole dialog text matched Medium twice. Co-authored-by: Tiankai Ma <tiankaima.dev@gmail.com>
The catalog group label still animates margin for 200ms after icon mode starts, so an early Courses click can land on Sections instead. Co-authored-by: Tiankai Ma <tiankaima.dev@gmail.com>
Co-authored-by: Tiankai Ma <tiankaima.dev@gmail.com>
Homework and todo popups keep one primary fact (due datetime) and one secondary line (relative urgency). Status, tags, priority, and other dates go in a table instead of chips or a collapsible. Co-authored-by: Tiankai Ma <tiankaima.dev@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Goal
Keep the homework/todo detail popups as a comfortable overlay (not a miniature two-column page), with an icon-only close control, and stay current with
main.Layout
Page two-column rules still apply on catalog/section pages. Overlays do not.
The overlay now uses one primary fact, one secondary line, then a table:
Primary: due datetime (large)
Secondary: relative urgency (
已逾期 …/还剩 …)Table (everything else):
Then description/content, then discussion. Completion / edit / delete stay in the footer.
There is no chip row, status side column, or collapsible “更多信息” in the dialog body. Close is an X with
aria-labelonly.Changed Surfaces
main(including the extracted homework dialog and shadcn dialog updates)docs/contracts/_ui.json/homework.json/todo.json— overlay facts: due, relative urgency, then a tablearia-label, nosr-onlylabel texttests/e2e/utils/detail-dialog.ts— table of remaining facts, reading width, icon-only closeEvidence
bunx svelte-check --tsconfig ./tsconfig.json— 0 errorsbunx biome checkon touched files — pass迭代二系统设计评审on/catalog/sections/9902001and workspace homeworks; opened todos期末报告提交/补交报告方案确认. Confirmed due + relative line + table, no chips, no body collapsible.Docs / Contracts
_ui.jsonLayout Principles: overlays lead with due datetime and relative urgency, then list remaining facts in a table, then reading, then discussion.Risk Areas
The section popup still hosts edit, completion, delete, audit history, and comments. Those handlers come from main; E2E covers the popup layout on top of them.
Cleanup
Removed the superseded dashboard-local dialog pieces (
DetailDialog.svelte,homework-detail-meta, etc.) in favor of main’s shared homework dialog. Screenshot PNGs were removed from the branch (including history) and are not stored in the repo.