Skip to content

fix(ci): report contract skip only for curriculum failures #55

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tiankaima-copilot merged 1 commit into from
Aug 27, 2026
Merged

fix(ci): report contract skip only for curriculum failures #55

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 15 additions & 1 deletion tests/test_verify_build.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,10 +3,24 @@
import unittest
from pathlib import Path

from tools.verify_build import verify_build
from tools.verify_build import _write_status_summary, verify_build


class BuildVerificationTest(unittest.TestCase):
def test_non_curriculum_failure_does_not_claim_contracts_were_skipped(self) -> None:
with tempfile.TemporaryDirectory() as temporary_dir:
summary_path = Path(temporary_dir) / "summary.md"
_write_status_summary(
summary_path,
{
"curriculum": {"status": "ok"},
"young": {"status": "failed"},
"rss": {"status": "ok"},
},
)

self.assertNotIn("skipped", summary_path.read_text(encoding="utf-8"))

def test_failed_authenticated_builders_skip_missing_contract_report(self) -> None:
with tempfile.TemporaryDirectory() as temporary_dir:
root = Path(temporary_dir)
Expand Down
3 changes: 1 addition & 2 deletions tools/verify_build.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,10 +58,9 @@ def _write_status_summary(
summary_path: Path | None,
builders: dict[str, dict[str, str]],
) -> None:
failed = [name for name in BUILDER_NAMES if builders[name]["status"] != "ok"]
lines = ["## Static build status\n\n", "| Builder | Status |\n", "|---|---|\n"]
lines.extend(f"| {name} | {builders[name]['status']} |\n" for name in BUILDER_NAMES)
if failed:
if builders["curriculum"]["status"] != "ok":
lines.extend(
[
"\n",
Expand Down
Loading