fix(chat): prevent group nickname cross-member binding - #136
Open
bluntvoice wants to merge 2 commits into
Open
Conversation
Treat field 1 target matches as current-layout evidence even when field 2 is absent. Require unambiguous display text before allowing legacy field 4 to field 1 mapping, and cover cross-member references without field 2.
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
chat_room.ext_buffermember layout from the legacy layout before resolving requested sendersRoot cause
The parser treated any requested username found in a member submessage as that record's owner. In current data, field 4 can reference another member while field 1 and field 2 belong to the actual record owner. A single-sender API request could therefore stop at the referenced record and return the wrong member's group nickname.
Validation
19 passed, 6 subtests passedacross the nickname parser and related chat display testsgit diff --checkpassedEnvironment note
The full public-source test run reached
1219 passed; remaining failures require private native runtime/broker components or optional model/export assets that are not present in this public checkout. The focused tests covering this change pass.