Repository navigation
fix(activate): restart discovery-client when it ignores a re-created … - #39
Merged
Merged
Conversation
…config (cold node) On the last deactivation the plugin disconnects the subsystem and removes its discovery-client config. On the next activation it rewrites the config and waits for discovery-client to connect, which after such a full teardown the daemon reliably did not do (LightOS 3.20.1, validated 2026-10-04: no reconnect for 9+ minutes, every `qm start` failing after the 60 s wait, while `systemctl restart discovery-client` made the next start succeed). activate_volume now nudges the daemon once if no connection shows up within $DSC_NUDGE_AFTER (10 s) of writing the config and keeps waiting up to $DSC_CONNECT_WAIT (45 s), warning in the task log why. Harmless for running guests: NVMe connections are kernel-owned and survive a daemon restart (even kill -9, verified live). t/activate_volume_cold_node.t covers no-nudge-when-connected, exactly one nudge then success, and the unchanged failure when nothing helps. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_016GZ6hHkdagCwHQXx8beKDk
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configuration
Comment |
This was referenced Oct 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…config (cold node)
On the last deactivation the plugin disconnects the subsystem and removes its discovery-client config. On the next activation it rewrites the config and waits for discovery-client to connect, which after such a full teardown the daemon reliably did not do (LightOS 3.20.1, validated 2026-10-04: no reconnect for 9+ minutes, every
qm startfailing after the 60 s wait, whilesystemctl restart discovery-clientmade the next start succeed).activate_volume now nudges the daemon once if no connection shows up within $DSC_NUDGE_AFTER (10 s) of writing the config and keeps waiting up to $DSC_CONNECT_WAIT (45 s), warning in the task log why. Harmless for running guests: NVMe connections are kernel-owned and survive a daemon restart (even kill -9, verified live).
t/activate_volume_cold_node.t covers no-nudge-when-connected, exactly one nudge then success, and the unchanged failure when nothing helps.
Claude-Session: https://claude.ai/code/session_016GZ6hHkdagCwHQXx8beKDk
Description
What does this change do and why?
Type of change
Testing
perl -c LightbitsPlugin.pmpassesshellcheck scripts/install.sh scripts/uninstall.shpassesTest notes:
DCO
By submitting this pull request I certify that my contribution is made under the terms of the Developer Certificate of Origin and that each commit includes a
Signed-off-byline (git commit -s).