PR72-F1 — hide obsolete Autoflow gap notice - #73
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Team Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
@codex review |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Codex Review: Didn't find any major issues. 🎉 Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
6018fd5
into
cockpit/d4-autoflow-projection-clean
Finding
Repairs PR72-F1 from parent PR #72.
Classification before repair:
CURRENT
Severity:
P2
Codex found that the D4 Cockpit rendered both:
on the same page when Autoflow projection data was supplied.
Repair
The Autoflow-specific gap notice is now conditional:
autoflow === null→ truthful Autoflow absence notice remains
autoflow !== null→ populated Autoflow panel renders and the obsolete gap notice is omitted
Other truthful capability gaps, including Tree SHA, remain visible.
Scope
Exactly 2 changed files:
src/cockpit-host/render.tstests/cockpit-host/render.test.tsNo D1/D2 changes.
No Autoflow transition execution.
No authority/policy changes.
No provider invocation.
No Ready/merge logic.
No unrelated UI redesign.
Validation
Frozen repair candidate:
Patch SHA256:
BF5467CE1158ACDFF2CE802CB2914B93F8AD8A0078E8F3F04CE0AD4B5C0BE330Patch bytes:
4454Independent fresh validation:
PASS
Evidence:
Repair HEAD:
b55a3c21cc1d17ca2fbc57489ad7a338a0d7e2baParent HEAD:
8e7dc84c63e4e68ea9590f91f6eaebc3bf9fcbc9Integration boundary
This is a stacked validation PR into:
cockpit/d4-autoflow-projection-cleanIt MUST NOT merge directly to
main.Parent PR #72 remains protected and Draft until this child completes its own validation lifecycle.
Status
DRAFT.
Do not merge yet.