Skip to content

PR72-F1 — hide obsolete Autoflow gap notice - #73

Merged
LogicDuke merged 1 commit into
cockpit/d4-autoflow-projection-cleanfrom
repair/pr72-f1-autoflow-gap-notice
Sep 4, 2026
Merged

PR72-F1 — hide obsolete Autoflow gap notice#73
LogicDuke merged 1 commit into
cockpit/d4-autoflow-projection-cleanfrom
repair/pr72-f1-autoflow-gap-notice

Conversation

@LogicDuke

Copy link
Copy Markdown
Owner

Finding

Repairs PR72-F1 from parent PR #72.

Classification before repair:
CURRENT

Severity:
P2

Codex found that the D4 Cockpit rendered both:

  • a populated Autoflow projection panel, and
  • the obsolete “Autoflow — not projected yet” gap notice

on the same page when Autoflow projection data was supplied.

Repair

The Autoflow-specific gap notice is now conditional:

  • autoflow === null
    → truthful Autoflow absence notice remains

  • autoflow !== null
    → populated Autoflow panel renders and the obsolete gap notice is omitted

Other truthful capability gaps, including Tree SHA, remain visible.

Scope

Exactly 2 changed files:

  • src/cockpit-host/render.ts
  • tests/cockpit-host/render.test.ts

No D1/D2 changes.
No Autoflow transition execution.
No authority/policy changes.
No provider invocation.
No Ready/merge logic.
No unrelated UI redesign.

Validation

Frozen repair candidate:

Patch SHA256:
BF5467CE1158ACDFF2CE802CB2914B93F8AD8A0078E8F3F04CE0AD4B5C0BE330

Patch bytes:
4454

Independent fresh validation:
PASS

Evidence:

  • focused render tests: 27 passed
  • cockpit-host tests: 47 passed
  • Cockpit tests: 151 passed
  • D4 projection tests: 21 passed
  • full repository suite: 1719 passed
  • typecheck: PASS
  • lint: PASS
  • build: PASS
  • git diff --check: PASS
  • adversarial/second-order validation: PASS
  • new findings: none

Repair HEAD:
b55a3c21cc1d17ca2fbc57489ad7a338a0d7e2ba

Parent HEAD:
8e7dc84c63e4e68ea9590f91f6eaebc3bf9fcbc9

Integration boundary

This is a stacked validation PR into:

cockpit/d4-autoflow-projection-clean

It MUST NOT merge directly to main.

Parent PR #72 remains protected and Draft until this child completes its own validation lifecycle.

Status

DRAFT.

Do not merge yet.

@coderabbitai

coderabbitai Bot commented Sep 4, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Team

Run ID: 4db0c587-58e0-4d01-9901-13e815d0a839

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@LogicDuke

Copy link
Copy Markdown
Owner Author

@codex review

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 4, 2026

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review Completed 2026-09-04T12:37:54.897229Z b55a3c2 Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. 🎉

Reviewed commit: b55a3c21cc

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@LogicDuke
LogicDuke marked this pull request as ready for review September 4, 2026 12:36
@LogicDuke
LogicDuke merged commit 6018fd5 into cockpit/d4-autoflow-projection-clean Sep 4, 2026
2 checks passed
@LogicDuke
LogicDuke deleted the repair/pr72-f1-autoflow-gap-notice branch September 4, 2026 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant