Skip to content

PR74-F1 — insulate Autoflow observation graph - #75

Merged
LogicDuke merged 1 commit into
cockpit/d4-stage-b-autoflow-provenancefrom
repair/pr74-f1-autoflow-prototype-insulation
Sep 4, 2026
Merged

PR74-F1 — insulate Autoflow observation graph#75
LogicDuke merged 1 commit into
cockpit/d4-stage-b-autoflow-provenancefrom
repair/pr74-f1-autoflow-prototype-insulation

Conversation

@LogicDuke

Copy link
Copy Markdown
Owner

PR74-F1 repairs the CURRENT P2 finding on parent PR #74.

Finding:
Accepted serialized Autoflow state could retain inherited realm prototype
toJSON hooks, allowing JSON.stringify(snapshot.autoflow) / JSON.stringify(snapshot)
to invoke attacker-controlled serialization behavior and violate D1's documented
plain-JSON round-trip invariant.

Repair:

  • hardens only the observation graph returned by readWorkflowState;
  • records are returned as null-prototype frozen objects;
  • lists remain arrays but carry an own non-enumerable non-callable toJSON shadow;
  • all returned values are detached and deeply frozen;
  • snapshotWorkflow, freezeState, openWorkflow, and applyWorkflowEvent remain unchanged;
  • no D1 schema or D4 projection change;
  • no authority expansion.

Validation before commit:

  • fresh independent validation;
  • 47/47 adversarial checks passed;
  • all 14 locked WF2 DONE conditions PROVEN;
  • full suite 30 files / 1761 tests passed;
  • typecheck PASS;
  • lint PASS;
  • build PASS;
  • git diff --check PASS.

Repair commit:
ef0ec70

Parent:
0e92fbf

@coderabbitai

coderabbitai Bot commented Sep 4, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Team

Run ID: b9a8ff46-a56b-4ad7-8fb5-fa039abd5486

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@LogicDuke
LogicDuke marked this pull request as ready for review September 4, 2026 17:09
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 4, 2026

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review Completed 2026-09-04T17:13:06.089983Z ef0ec70 Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@LogicDuke
LogicDuke merged commit f9e8cb6 into cockpit/d4-stage-b-autoflow-provenance Sep 4, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant