PR74-F1 — insulate Autoflow observation graph - #75
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Team Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
f9e8cb6
into
cockpit/d4-stage-b-autoflow-provenance
PR74-F1 repairs the CURRENT P2 finding on parent PR #74.
Finding:
Accepted serialized Autoflow state could retain inherited realm prototype
toJSON hooks, allowing JSON.stringify(snapshot.autoflow) / JSON.stringify(snapshot)
to invoke attacker-controlled serialization behavior and violate D1's documented
plain-JSON round-trip invariant.
Repair:
Validation before commit:
Repair commit:
ef0ec70
Parent:
0e92fbf