Skip to content

PR74 D1-contract — document schema v2 Autoflow envelope - #77

Closed
LogicDuke wants to merge 2 commits into
cockpit/d4-stage-b-autoflow-provenancefrom
repair/pr74-d1-schema-v2-contract
Closed

PR74 D1-contract — document schema v2 Autoflow envelope#77
LogicDuke wants to merge 2 commits into
cockpit/d4-stage-b-autoflow-provenancefrom
repair/pr74-d1-schema-v2-contract

Conversation

@LogicDuke

Copy link
Copy Markdown
Owner

Repairs the CURRENT P2 D1 architecture-contract mismatch on parent PR #74.

The runtime implementation already uses Cockpit snapshot schema version 2 and
requires an Autoflow observation, but the D1 architecture contract still
described V1 / no Autoflow integration.

This repair is documentation-only.

Scope:

  • docs/architecture/D1-cockpit-read-model.md only

The updated contract documents:

  • schemaVersion 2 as the only accepted version;
  • rejection of V1, absent, and unsupported versions;
  • required autoflow field;
  • absent/null/valid/malformed Autoflow semantics;
  • whole-snapshot rejection on invalid Autoflow;
  • repositoryId binding between snapshot repository and Autoflow state;
  • Autoflow as observation/display data only;
  • no transition, Policy, provider, repair, Ready, or merge authority;
  • existing JSON round-trip guarantee.

No runtime code, tests, fixtures, schema behavior, authority, or D4 projection
behavior changes.

Independent validation:
PASS_INDEPENDENT_VALIDATION

Validated semantic patch:
fa444a87f8b76038774efb296f0713c703745f341c7d119b8df4d65667405649
4402 bytes

Repair commit:
a5469c7

Parent:
c0ea1e7

@coderabbitai

coderabbitai Bot commented Sep 5, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Team

Run ID: 953fc6dc-2a15-4746-8f59-789eec904283

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@LogicDuke
LogicDuke marked this pull request as ready for review September 5, 2026 01:41
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 5, 2026

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review Completed 2026-09-05T02:21:47.282384Z c103106 Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: a5469c7e98

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread docs/architecture/D1-cockpit-read-model.md
@LogicDuke
LogicDuke marked this pull request as draft September 5, 2026 01:48
@LogicDuke
LogicDuke marked this pull request as ready for review September 5, 2026 02:19

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: c103106d5c

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment on lines +30 to +33
The serialized/collector provenance boundary — re-reading a workflow state from
hostile JSON — has since **landed in the D1 Cockpit snapshot reader**, exactly
where this Stage-A note anticipated it belongs, not in D4. Under Cockpit snapshot
**schema version 2** the D1 envelope carries a **required** `autoflow` field: a

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Update the stale Stage-A integration and next gate

Fresh evidence in this revision is this new declaration that serialized Autoflow ingestion has landed, which makes later sections of the same active contract contradictory: “Host integration” still says the Stage-A host supplies no workflow (lines 111–117), and “Recommended next gate” still proposes deciding how WorkflowState should cross the D1 serialization boundary (lines 121–124). The checked implementation already projects read.snapshot.autoflow in src/cockpit-host/server.ts lines 62–71, so update or supersede both obsolete sections as part of the Stage-B synchronization.

Useful? React with 👍 / 👎.

@LogicDuke

Copy link
Copy Markdown
Owner Author

Superseded by PR #78.

PR #78 rebuilt D4 Stage B from current main as one coherent, independently validated replacement and has now been merged successfully.

This PR is preserved as historical repair evidence and must not be merged.

@LogicDuke LogicDuke closed this Sep 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant