PR74 D1-contract — document schema v2 Autoflow envelope - #77
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Team Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: a5469c7e98
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: c103106d5c
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| The serialized/collector provenance boundary — re-reading a workflow state from | ||
| hostile JSON — has since **landed in the D1 Cockpit snapshot reader**, exactly | ||
| where this Stage-A note anticipated it belongs, not in D4. Under Cockpit snapshot | ||
| **schema version 2** the D1 envelope carries a **required** `autoflow` field: a |
There was a problem hiding this comment.
Update the stale Stage-A integration and next gate
Fresh evidence in this revision is this new declaration that serialized Autoflow ingestion has landed, which makes later sections of the same active contract contradictory: “Host integration” still says the Stage-A host supplies no workflow (lines 111–117), and “Recommended next gate” still proposes deciding how WorkflowState should cross the D1 serialization boundary (lines 121–124). The checked implementation already projects read.snapshot.autoflow in src/cockpit-host/server.ts lines 62–71, so update or supersede both obsolete sections as part of the Stage-B synchronization.
Useful? React with 👍 / 👎.
Repairs the CURRENT P2 D1 architecture-contract mismatch on parent PR #74.
The runtime implementation already uses Cockpit snapshot schema version 2 and
requires an Autoflow observation, but the D1 architecture contract still
described V1 / no Autoflow integration.
This repair is documentation-only.
Scope:
The updated contract documents:
No runtime code, tests, fixtures, schema behavior, authority, or D4 projection
behavior changes.
Independent validation:
PASS_INDEPENDENT_VALIDATION
Validated semantic patch:
fa444a87f8b76038774efb296f0713c703745f341c7d119b8df4d65667405649
4402 bytes
Repair commit:
a5469c7
Parent:
c0ea1e7