Cockpit D5 — add serialized live snapshot ingestion - #80
Conversation
Add a read-only serialized snapshot producer, an explicit host source seam, and source-derived provenance labeling, so the Cockpit can ingest a live Autoflow observation through the unchanged D1 hostile boundary while preserving every read-only, workflow-truth, and human-authority boundary. Schema v2 and the five protected implementation boundaries are byte-unchanged; a failed live source fails closed with no fixture fallback. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013Ma5jqtnq1VEZc94QLkn89
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Team Run ID: 📒 Files selected for processing (6)
Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review. 📝 WalkthroughWalkthroughThe PR adds a pure schema-v2 snapshot producer and a ChangesD5 live Cockpit ingestion
Estimated code review effort: 3 (Moderate) | ~25 minutes Merge Risk: ⚪ Minimal · up to This change adds bounded live snapshot ingestion while preserving fixture defaults, rejecting invalid live data, and clearly labeling live versus fixture output. The documented validation and coverage support merge readiness with no remaining actionable risk. Sequence Diagram(s)sequenceDiagram
participant CockpitSource
participant buildDashboardHtml
participant readCockpitSnapshot
participant renderDashboard
CockpitSource->>buildDashboardHtml: read serialized snapshot
buildDashboardHtml->>readCockpitSnapshot: validate raw snapshot
readCockpitSnapshot-->>buildDashboardHtml: validated CockpitSnapshot
buildDashboardHtml->>renderDashboard: render snapshot with source mode
renderDashboard-->>buildDashboardHtml: dashboard HTML
Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
Full details: Docstring CoverageExplanation Docstring coverage is 75.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 12 functions across 5 files. (1 skipped: 1 unsupported.)
✨ Finishing Touches 💡 1📝 Generate docstrings 💡
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
@codex review |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 6304f12160
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Default optional read-model lists only when absent (undefined), via a defaultOptionalList helper, instead of a nullish `?? []` default. An explicit null (or any other malformed runtime value) now survives the producer serialization boundary and reaches readCockpitSnapshot, which rejects the whole snapshot. This removes a sanitization; it adds no producer-side validation, so D1 remains the sole hostile-input validator. Schema v2 and the protected boundaries are unchanged; defaultBranchRef keeps its legitimate null default. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013Ma5jqtnq1VEZc94QLkn89
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: dede936afc
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
@coderabbitai review |
✅ Action performedReview finished.
|
1 participant
Cockpit D5 introduces the bounded live-snapshot ingestion capability adopted by the Commander DDR.
Architecture:
Autoflow authoritative WorkflowState
→ read-only serialized snapshot producer
→ JSON serialization firewall
→ readCockpitSnapshot(unknown)
→ existing D2/D4 projections
→ read-only Cockpit rendering
Scope:
Authority remains unchanged:
Strong unchanged boundaries:
Validation:
Exact candidate:
Commit:
6304f12
Parent:
068a523
Patch SHA256:
2c0b9d48e17e549a41966a0559746e27f5177f4917e7bd39689df2823769ca8f
Patch bytes:
35254
Known non-blocking observations:
🤖 Generated with Claude Code
https://claude.ai/code/session_013Ma5jqtnq1VEZc94QLkn89
Summary by CodeRabbit