Skip to content

fix(dns): correct records delete help text - #429

Merged
pcfreak30 merged 1 commit into
developfrom
fix/dns-help-audit
Aug 20, 2026
Merged

fix(dns): correct records delete help text#429
pcfreak30 merged 1 commit into
developfrom
fix/dns-help-audit

Conversation

@pcfreak30

@pcfreak30 pcfreak30 commented Aug 20, 2026

Copy link
Copy Markdown
Member

Summary

Fixes the dns records delete help text in two ways:

  1. Incorrect behavior: it claimed deleting a record removes "one record only". DNS records are grouped by name + type, so the operation removes every value for that name/type (e.g. all TXT records at the same name). The text now states this plainly.

  2. Wrong command reference: it pointed users to dns_zones_delete — an internal operation identifier, not a command a user can run. It now references the CLI command form, pinner dns zones delete.


This pull request corrects the help text for the dns_records_delete operation in the DNS catalog.

The previous description incorrectly stated that the operation "Deletes one record only," which was misleading. The updated description clarifies that this operation actually deletes all DNS records matching the specified zone, name, and type, since DNS records are grouped by name+type (e.g., all TXT records at the same name are removed together).

The revised help text now:

  • Accurately explains that the operation is destructive and irreversible
  • Clarifies the grouping behavior (all values for a name+type combination are removed)
  • Updates the example command reference from dns_zones_delete to the proper CLI syntax pinner dns zones delete

This change improves user understanding of the command's actual behavior, preventing accidental data loss from mistaken expectations that only a single record would be affected.

@kody-ai

kody-ai Bot commented Aug 20, 2026

Copy link
Copy Markdown

Kody Review Complete

Great news! 🎉
No issues were found that match your current review configurations.

Keep up the excellent work! 🚀

Kody Guide: Usage and Configuration
Interacting with Kody
  • Request a Review: Ask Kody to review your PR manually by adding a comment with the @kody start-review command at the root of your PR.

  • Validate Business Logic: Ask Kody to validate your code against business rules by adding a comment with the @kody -v business-logic command.

  • Provide Feedback: Help Kody learn and improve by reacting to its comments with a 👍 for helpful suggestions or a 👎 if improvements are needed.

Current Kody Configuration
Review Options

The following review options are enabled or disabled:

Options Enabled
Bug
Performance
Security
Business Logic

Access your configuration settings here.

@github-actions

Copy link
Copy Markdown

Code Coverage Report

Total Coverage: 49.3%

Generated from commit: 83755f9
Repository: LumeWeb/pinner-cli

@pcfreak30
pcfreak30 marked this pull request as ready for review August 20, 2026 01:05
@pcfreak30
pcfreak30 merged commit 1933023 into develop Aug 20, 2026
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant