fix(dns): correct records delete help text - #429
Merged
Conversation
Kody Review CompleteGreat news! 🎉 Keep up the excellent work! 🚀 Kody Guide: Usage and ConfigurationInteracting with Kody
Current Kody ConfigurationReview OptionsThe following review options are enabled or disabled:
|
Code Coverage ReportTotal Coverage: 49.3% Generated from commit: 83755f9 |
pcfreak30
marked this pull request as ready for review
August 20, 2026 01:05
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the
dns records deletehelp text in two ways:Incorrect behavior: it claimed deleting a record removes "one record only". DNS records are grouped by name + type, so the operation removes every value for that name/type (e.g. all TXT records at the same name). The text now states this plainly.
Wrong command reference: it pointed users to
dns_zones_delete— an internal operation identifier, not a command a user can run. It now references the CLI command form,pinner dns zones delete.This pull request corrects the help text for the
dns_records_deleteoperation in the DNS catalog.The previous description incorrectly stated that the operation "Deletes one record only," which was misleading. The updated description clarifies that this operation actually deletes all DNS records matching the specified zone, name, and type, since DNS records are grouped by name+type (e.g., all TXT records at the same name are removed together).
The revised help text now:
dns_zones_deleteto the proper CLI syntaxpinner dns zones deleteThis change improves user understanding of the command's actual behavior, preventing accidental data loss from mistaken expectations that only a single record would be affected.