Skip externals update when already up to date - #1502
Open
fmahebert wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is a possible fix to #1501
The PR branch first runs
checkout_externals --statusto check whether the external versions match what is inExternals.cfg. Only if there is a mismatch do we fall back to remote git operations to update the local copy. We determine the mismatch by parsing the output of the status command.Tested by running locally and observing (a) out-of-date externals are still updated from upstream, and (b) up-to-date externals are now verified locally and network access is skipped.
This saves 3-4 seconds of configure time on my dev system.