Item Durability Logic Refactor by ze-dom · Pull Request #966 · MUnique/OpenMU

ze-dom · 2026-09-16T13:50:52Z

To-do

Comment changes with source references
UpdatePlugin(s)

Developments

Added durability thresholds, past which some of the item power-ups decrease by a certain factor
Added DurabilityDecayPlugIn.cs, for jewelry and wings durability decrease
Reworked durability reduction calculations to reflect original values while keeping it configurable

Bugfixes

Possible durability reduction target items after dealing and receiving damage
Master tree logic and values for skills DurabilityReduction1, DurabilityReduction2, DurabilityReduction3, PetDurabilityStr, DurabilityReduction1FistMaster, DurabilityReduction2FistMaster, DurabilityReduction3FistMaster
Repairing items now raises the event EquippedItemsChanged. Previously repaired items w/ durability = 0 were not removing their power-ups.

…epairing items

ze-dom · 2026-09-22T16:38:03Z

+        bool isPvpDamage = attacker is Player or IPlayerSurrogate;
+        float damage = isPvpDamage ? hitInfo.TotalDamage : attacker.Attributes[Stats.MinimumPhysBaseDmg];
+        await this.DecreaseItemDurabilityAfterHitAsync(damage, isPvpDamage, skill).ConfigureAwait(false);


zTeamS6.3: ObjAttack.cpp, user.cpp
emu: ObjAttack.cpp, user.cpp

ze-dom · 2026-09-22T16:43:55Z

            if (attacker is Player player)
            {
-                await player.AfterHitTargetAsync().ConfigureAwait(false);
+                await player.AfterHitTargetAsync(this.Attributes[Stats.DefensePvm], skill?.Skill?.DamageType).ConfigureAwait(false);


zTeamS6.3: ObjAttack.cpp, user.cpp
emu: ObjAttack.cpp, user.cpp

ze-dom · 2026-09-22T16:48:37Z

            if (attacker as IPlayerSurrogate is { } playerSurrogate)
            {
-                await playerSurrogate.Owner.AfterHitTargetAsync().ConfigureAwait(false);
+                await playerSurrogate.Owner.DecreaseRavenDurabilityAfterHitAsync(hitInfo.TotalDamage).ConfigureAwait(false);


zTeamS6.3, emu

Unfortunately Dark Raven durability decrease is originally calculated in the middle of damage calcs, so we diverge here a bit.

ze-dom · 2026-09-22T19:45:48Z

            this.AddRandomExcellentOptions(resultItem, player);

+            resultItem.Durability = craftingResultItem.Durability ?? resultItem.GetMaximumDurabilityOfOnePiece();
+


Durability depends on item being excellent

ze-dom · 2026-09-22T19:47:03Z

Moved to Player.cs

ze-dom · 2026-09-22T19:52:10Z

zTeamS6.3, emu

ze-dom · 2026-09-22T20:30:22Z

+                        {
+                            double decrementWeight = new ItemIdentifier(item.Definition!.Number, item.Definition.Group) switch
+                            {
+                                var _ when isTransformationRing => 11.28, // 11.28 / 564 = 0.02


zTeamS6.3, emu

ze-dom · 2026-09-22T20:37:36Z

+                                durationIncrease = 1;
+                            }
+
+                            var decrement = decrementWeight / (player.GameContext.Configuration.HitsPerOneItemDurability * durationIncrease);


zTeamS6.3, emu
564 hard limit check

ze-dom · 2026-09-23T13:27:27Z

    /// </summary>
-    public static AttributeDefinition ItemDurationIncrease { get; } = new(new Guid("03EBE702-90FF-473C-8CBB-E83669FE3C68"), "Item Duration Increase", string.Empty);
+    /// <remarks>Includes weapons, shields and armor items. Excludes jewelry, wings and pets.</remarks>
+    public static AttributeDefinition WeaponAndArmorDurationIncrease { get; } = new(new Guid("03EBE702-90FF-473C-8CBB-E83669FE3C68"), "Weapon And Armor Duration Increase (MST)", string.Empty);


zTeamS6.3, emu

The tooltip is inaccurate: it's actually 67% increase: zTeamS6.3, emu.

ze-dom · 2026-09-23T13:28:22Z

+    /// Gets the jewelry and wings duration increase MST attribute definition.
    /// </summary>
-    public static AttributeDefinition PetDurationIncrease { get; } = new(new Guid("B4455150-D3A9-4A5F-914B-F41F9387FE9A"), "Pet Duration Increase", string.Empty);
+    public static AttributeDefinition JewelryAndWingsDurationIncrease { get; } = new(new Guid("E539FDD2-72C5-484A-B0F4-40565ABAEDD9"), "Jewelry And Wings Duration Increase (MST)", string.Empty);


zTeamS6.3, emu

The tooltip is inaccurate: it's actually 67% increase: zTeamS6.3, emu.

ze-dom · 2026-09-23T13:29:30Z

+    /// Gets the pet duration increase MST attribute definition.
+    /// </summary>
+    /// <remarks>Applies to imp, guardian angel, uniria, dinorant and fenrir. Cash shop items excluded.</remarks>
+    public static AttributeDefinition PetDurationIncrease { get; } = new(new Guid("E9CCA156-E0DE-4113-A249-B7CD4C0F610D"), "Pet Duration Increase (MST)", string.Empty);


zTeamS6.3, emu

The tooltip is inaccurate: it's actually x66.78 increase: zTeamS6.3 (missing), emu.

ze-dom · 2026-09-23T13:33:04Z

+    /// <summary>
+    /// Gets the trainable pet (dark horse, dark raven) duration increase MST attribute definition.
+    /// </summary>
+    public static AttributeDefinition TrainablePetDurationIncrease { get; } = new(new Guid("B4455150-D3A9-4A5F-914B-F41F9387FE9A"), "Trainable Pet Duration Increase (MST)", string.Empty);


zTeamS6.3, emu

The tooltip is innacurate: it's not actually %, but absolute in this case:
zTeamS6.3: Horse, Raven
emu: Horse, Raven.

ze-dom · 2026-09-23T14:00:35Z

Move this to Player.cs, where all durability reduction is addressed.

ze-dom · 2026-09-23T14:03:11Z

+                            double decrementWeight = identifier switch
+                            {
+                                var _ when isTransformationRing => 11.28, // 11.28 / 564 = 0.02
+                                var itm when itm == ItemConstants.WizardsRing => 7,


zTeamS6.3, emu

ze-dom · 2026-09-23T14:06:38Z

+                            {
+                                var _ when isTransformationRing => 11.28, // 11.28 / 564 = 0.02
+                                var itm when itm == ItemConstants.WizardsRing => 7,
+                                var itm when itm == ItemConstants.MoonstonePendant => 6.3,


zTeamS6.3, emu
"Pendant" that goes on ring slot 😅

ze-dom · 2026-09-23T14:14:04Z

    private static readonly byte[] AdditionalDurabilityPerLevel = { 0, 1, 2, 3, 4, 6, 8, 10, 12, 14, 17, 21, 26, 32, 39, 47 };

+    private static readonly float[] DurabilityFactors = { 0.2f, 0.3f, 0.5f };
+


zTeamS6.3, emu

ze-dom · 2026-09-23T14:16:30Z

+            if (!(left?.IsWizardryWeapon(out _) ?? true) || (left?.CanHaveSkill() ?? false))
+            {
+                left = null;
+            }


We need the second condition to clear MG "magic swords"

ze-dom · 2026-09-23T14:18:09Z

+        var maxDurability = item.GetMaximumDurabilityOfOnePiece();
+        for (int i = 0; i < DurabilityFactors.Length; i++)
+        {
+            item.DurabilityThresholds[i] = maxDurability * DurabilityFactors[i];


zTeamS6.3, emu

ze-dom · 2026-09-23T14:20:15Z

+        {
+            if (item.Durability < item.DurabilityThresholds[i])
+            {
+                return 1 - DurabilityFactors[^(i + 1)];


zTeamS6.3, emu

ze-dom · 2026-09-23T14:25:56Z

+        Stats.StaffRise,
+        Stats.ScepterRise,
+        Stats.BookRise,
+    ];


zTeamS6.3: zzzitem.cpp, ObjAttack.cpp, DarkSpirit.cpp
emu: zzzitem.cpp, ObjAttack.cpp, DarkSpirit.cpp

ze-dom · 2026-09-23T14:43:19Z


-            foreach (var wrapper in PowerUpWrapper.CreateByPowerUpDefinition(powerUp, attributeHolder, aggregateType))
+            var durabilityFactor = (option.OptionType == ItemOptionTypes.Option && !item.IsJewelry()) || option.OptionType == ItemOptionTypes.AncientBonus
+                ? item.GetCurrentDurabilityFactor() : 1.0f;


zTeamS6.3: zzzitem.cpp (regular item options - except rings and wings hp rec), zzzitem.cpp (ancient bonus opt)
emu: zzzitem.cpp, zzzitem.cpp

ze-dom · 2026-09-23T14:59:31Z

        if (attacker is Player attackerPlayer)
        {
-            await attackerPlayer.AfterHitTargetAsync().ConfigureAwait(false);
+            await attackerPlayer.AfterHitTargetAsync(this.Attributes[Stats.DefenseFinal], skill?.Skill?.DamageType).ConfigureAwait(false);


zTeamS6.3: ObjAttack.cpp, user.cpp
emu: ObjAttack.cpp, user.cpp

ze-dom · 2026-09-23T15:01:34Z

+            item.PetExperience = (int)Math.Max((int)(item.PetExperience * 0.9), minimumExp);
+            await this.ResetPetBehaviorAsync().ConfigureAwait(false);
+        }
+    }


zTeamS6.3, emu

ze-dom · 2026-09-23T15:08:17Z

+        if (!isPvpDamage)
+        {
+            var randomDefensiveItem = this.Inventory?.EquippedItems.Where(ItemExtensions.IsDefensiveItem).SelectRandom();
+            if (randomDefensiveItem is { Durability: > 0.0 })
+            {
+                await this.DecreaseDefenseItemDurabilityAsync(randomDefensiveItem, damage).ConfigureAwait(false);
+            }
+        }


Only mobs have m_AttackDamageMin > 0
zTeamS6.3, emu

I think this also makes sense, because otherwise all PvP would wear armor down.

ze-dom · 2026-09-23T15:13:36Z

    }

-    private async ValueTask DecreaseDefenseItemDurabilityAsync(Item targetItem, HitInfo hitInfo)
+    private async ValueTask DecreaseDefenseItemDurabilityAsync(Item targetItem, float damage)


zTeamS6.3, emu

ze-dom · 2026-09-23T15:15:20Z

-                    await this.DestroyInventoryItemAsync(pet).ConfigureAwait(false);
-                }
-            }
+            await this.DecreasePetDurabilityAsync(pet, damage).ConfigureAwait(false);


zTeamS6.3, emu

Unfortunately pet durability decrease is originally calculated in the middle of damage calcs, so we diverge here a bit.

ze-dom · 2026-09-23T15:18:17Z

    }

-    private async ValueTask DecreaseWeaponDurabilityAfterHitAsync()
+    private async ValueTask DecreasePetDurabilityAsync(Item pet, float damage)


zTeamS6.3, emu

ze-dom · 2026-09-23T15:25:32Z

+            var item when item == ItemConstants.Angel
+                       || item == ItemConstants.Rudolf => 3,
+            var item when item == ItemConstants.Imp
+                       || item == ItemConstants.DarkHorse
+                       || item == ItemConstants.Fenrir => 2,
+            var item when item == ItemConstants.Dinorant => 10,
+            var item when item == ItemConstants.Demon => 1.5,
+            _ => 1,


zTeamS6.3, emu

A little bit of divergence between the two sources regarding dinorant and the cash shop pets. Went with emu because it has the master skill increase in place, which is missing in zTeamS6.3.

ze-dom · 2026-09-23T15:30:50Z

+        {
+            decrement = 1 + (damage * damageFactor / damagePerOnePetDurability);
+            decrement /= 1500 + itemDurationIncrease;
+        }


zTeamS6.3, emu

ze-dom · 2026-09-23T15:31:26Z

+        {
+            decrement = 1 + (damage * damageFactor / (damagePerOnePetDurability * itemDurationIncrease));
+            decrement /= attributes[Stats.ArcheryMaxDmg] > 0 ? 160 : 200;
+        }


zTeamS6.3, emu

Elf-or-else divisor: emu

ze-dom · 2026-09-23T15:39:09Z

+
+                    await this._movement.StopWalkingAsync().ConfigureAwait(false);
+                    await this.WarpToSafezoneAsync().ConfigureAwait(false);
+                }


zTeamS6.3, emu

Note: Icarus safezone map is actually Devias, not Lost Tower => todo

ze-dom · 2026-09-23T15:42:28Z

+        }
+    }
+
+    private async ValueTask DecreaseWeaponDurabilityAfterHitAsync(float targetDefense, DamageType damageType)


NormalWeaponDurabilityDown(): zTeamS6.3, emu
BowWeaponDurabilityDown(): zTeamS6.3, emu
StaffWeaponDurabilityDown(): zTeamS6.3, emu

ze-dom · 2026-09-23T15:49:46Z

+            && pu.Boost?.ConstantValue is { } socketInc)
+        {
+            defenseToDamageRatio -= defenseToDamageRatio * socketInc.Value;
+        }


zTeamS6.3: zzzitem.cpp, ItemSocketOptionSystem.cpp
emu: zzzitem.cpp,, SocketOptionSystem.cpp

ze-dom · 2026-09-23T15:58:04Z

-        this.GameConfiguration.HitsPerOneItemDurability = 10000;
+        this.GameConfiguration.DamagePerOneItemDurability = 69;
+        this.GameConfiguration.DamagePerOnePetDurability = 100;
+        this.GameConfiguration.HitsPerOneItemDurability = 564;


zTeamS6.3: NormalWeaponDurabilityDown() (weapons), DurabilityDown() (jewelry and wings)
emu: NormalWeaponDurabilityDown(), DurabilityDown()

ze-dom · 2026-09-23T15:59:40Z

-        this.GameConfiguration.DamagePerOnePetDurability = 100000;
-        this.GameConfiguration.HitsPerOneItemDurability = 10000;
+        this.GameConfiguration.DamagePerOneItemDurability = 69;
+        this.GameConfiguration.DamagePerOnePetDurability = 100;


zTeamS6.3, emu

ze-dom · 2026-09-23T16:01:01Z

-        this.GameConfiguration.DamagePerOneItemDurability = 2000;
-        this.GameConfiguration.DamagePerOnePetDurability = 100000;
-        this.GameConfiguration.HitsPerOneItemDurability = 10000;
+        this.GameConfiguration.DamagePerOneItemDurability = 69;


zTeamS6.3, emu

sven-n

Nice work — the direction looks good to me: the time-decay plug-in, the durability → power-up factor, and the repair event fix all make sense, and the update plug-ins cover the three data versions. A quick review with a few things that stood out.

Blocking

ItemDurabilityRefactorPlugInSeason6.cs doesn't compile (assignment to a null-conditional access). That's very likely the failing MUnique.OpenMU check.
The *DurationIncrease stats are used as divisors while the master skills feed them values below 1, so putting points into the durability skills currently makes items decay faster (~8x at skill level 1). Details inline.

Worth a second look

Unit inconsistency across the four durability master skills (percent vs. factor, multiplied vs. added).
Possible NullReferenceException from ItemPowerUps.FirstOrDefault(...).Value in both durability paths.
GetRandomWeapon: the left-hand-staff case nulls the right hand.
Two behaviour changes that aren't in the description: Plasma Storm's 25% chance is now 100%, and defensive items no longer lose durability in PvP.
DurabilityThresholds cache: [NotMapped] vs. the repo's [Transient] convention, and manual invalidation that a few item.Level writers miss.

Nits

ItemDurabilityRefactorPlugIn075.ApplyAsync only calls base — the override can go; ItemDurabilityRefactorPlugInBase.ApplyAsync is async without an await (CS1998), plus a stray blank line before });.
Stale resources left behind: PlasmaStormSkillPlugIn_Name / _Description (plug-in deleted) and ItemBasePowerUpDefinition_BaseValueElement_* (property removed).
PlugInResources.Designer.cs lost its UTF-8 BOM, and the new .resx entry is indented by four spaces instead of two.
GetRandomWeapon mixes !(x ?? true) and !x ?? true in adjacent branches — both work, but they read as if one is a typo.
ItemPowerUpFactory:342 now uses IsArmorItem() where it was IsDefenseItemSlot && !IsJewelry, which drops wings from the excellent/ancient defense bonus. Harmless in practice, but it is a semantic change.

Generated by Claude Code

sven-n · 2026-09-24T17:41:05Z

+                levelOption.PowerUpDefinition?.TargetAttribute = weaponDurationIncrease;
+                levelOption.PowerUpDefinition?.Boost?.ConstantValue.Value -= 1.0f;
+                levelOption.PowerUpDefinition?.Boost?.ConstantValue.AggregateType = AggregateType.AddRaw;


This doesn't compile: a null-conditional access can't be the target of an assignment (CS0131), which applies to all three lines (including the compound -=). This is most likely why the MUnique.OpenMU build check is red.

Something like this works:

foreach (var levelOption in durationIncrease.LevelDependentOptions) { if (levelOption.PowerUpDefinition is not { } powerUpDefinition) { continue; } powerUpDefinition.TargetAttribute = weaponDurationIncrease; if (powerUpDefinition.Boost?.ConstantValue is { } constantValue) { constantValue.Value -= 1.0f; constantValue.AggregateType = AggregateType.AddRaw; } }

Generated by Claude Code

Is the pipeline using an older version of C#? This compiles on my machine.
Since C# 14 null-conditional assignment is allowed.

But I can change if needed.

sven-n · 2026-09-24T17:41:15Z

+        float itemDurationIncrease = attributes[Stats.WeaponAndArmorDurationIncrease];
        if (itemDurationIncrease == 0)
        {
            itemDurationIncrease = 1;
        }


The duration-increase stat is used as a divisor, but the master skills now feed it values below 1, so investing skill points makes items decay faster.

DurabilityReduction1 (and DurabilityReduction1FistMaster) is AddRaw of Formula1204 / 100, which is ~0.12 at skill level 1 and ~0.90 at level 20. The == 0 → 1 guard only covers "no skill at all", so:

skill level 1 → decrement = ratio / (69 * 0.12) ⇒ ~8x faster durability loss than without the skill

skill level 20 → ratio / (69 * 0.90) ⇒ still ~11% faster than without the skill

I think it wants to be a bonus on top of 1:

float itemDurationIncrease = 1 + attributes[Stats.WeaponAndArmorDurationIncrease];

and then the if (itemDurationIncrease == 0) guard can go away.

The same pattern is in DecreaseWeaponDurabilityAfterHitAsync (line ~2201) and in DurabilityDecayPlugIn (JewelryAndWingsDurationIncrease), both fed by Formula1204 / 100 skills as well.

Generated by Claude Code

sven-n · 2026-09-24T17:41:25Z

+        if (identifier == ItemConstants.DarkHorse)
+        {
+            decrement = 1 + (damage * damageFactor / damagePerOnePetDurability);
+            decrement /= 1500 + itemDurationIncrease;


The four durability master skills end up with three different units, which makes their effects wildly inconsistent:

DurabilityReduction1/2 (+ fist master variants) → Formula1204 / 100 (0.12 … 0.90), used as a multiplicative divisor — see the separate comment, this one currently backfires.

DurabilityReduction3 / DurabilityReduction3FistMaster → raw Formula1204 (12 … 90) for PetDurationIncrease, also used as a multiplicative divisor (damagePerOnePetDurability * itemDurationIncrease) ⇒ 12x slower pet decay from a single skill point, up to 90x.

PetDurabilityStr → raw Formula1204 for TrainablePetDurationIncrease, but added to a constant here (1500 + …) and in DecreaseRavenDurabilityAfterHitAsync (800 + …) ⇒ a ~1–6% effect.

Was the missing / 100 on DurabilityReduction3/3FistMaster intentional? It would be good to settle on one unit (percentage or factor) for the whole family and apply it the same way in all consumers.

Generated by Claude Code

That's the way the sources go...

sven-n · 2026-09-24T17:41:31Z

+            var itemPowerUps = attributes.ItemPowerUps.FirstOrDefault(ipu => ipu.Key == targetItem).Value;
+            itemDefense = attributes.GetComposableAttribute(Stats.DefenseBase)?.Elements
+                .Where(e => e.AggregateType == AggregateType.AddRaw && itemPowerUps.Contains(e))
+                .Sum(e => e.Value) ?? 0;


FirstOrDefault on a KeyValuePair returns default when the item isn't in the dictionary, so itemPowerUps can be null and itemPowerUps.Contains(e) then throws a NullReferenceException — the ?? 0 only guards GetComposableAttribute returning null.

TryGetValue avoids that and is O(1) instead of scanning the whole dictionary on every hit:

if (!attributes.ItemPowerUps.TryGetValue(targetItem, out var itemPowerUps)) { return; }

Same at line ~2228 in DecreaseWeaponDurabilityAfterHitAsync.

Generated by Claude Code

sven-n · 2026-09-24T17:41:38Z

+        else
+        {
+            if (left?.Definition?.Group == StaffItemGroup || right?.Definition?.Group == StaffItemGroup)
+            {
+                right = null;
+            }


This nulls the right hand when the left one holds the staff — is that intended, or should the staff itself (left) be excluded from taking durability loss on a non-magic hit? As written, a left-hand staff both survives the filter and removes the right-hand weapon from the selection, so the staff is always the one that loses durability.

Generated by Claude Code

Intended. With the exception of Summoner, a LH staff is always the "main" weapon, magic or non-magic attack.

sven-n · 2026-09-24T17:42:05Z

+    [NotMapped]
+    public double[]? DurabilityThresholds { get; set; }


Two things about this cache:

The repo's convention for non-persisted, run-time-only members is [Transient] (MUnique.OpenMU.Annotations), which both EfCoreModelGenerator and the generated MapsterConfigurator key off. [NotMapped] keeps it out of the EF schema, but the mapping layer will still copy the array reference between the entity and the data model. [NotMapped] is otherwise not used anywhere in DataModel.

The cache is invalidated by hand in five places (UpgradeItemLevelJewelConsumeHandlerPlugIn, BaseItemCraftingHandler x2, SimpleItemCraftingHandler, ItemViewModel x2), and other places that change item.Level don't reset it — e.g. BaseEventTicketCrafting.cs:107 and the bot gear equippers. It'd be more robust to store the level (and ancient/excellent state) the thresholds were computed for and recompute on mismatch, so it can't go stale by omission.

Generated by Claude Code

sven-n · 2026-09-24T17:42:12Z

+            var previousFactor = item.GetCurrentDurabilityFactor();
            item.Durability = item.GetMaximumDurabilityOfOnePiece();
+            if (previousFactor != item.GetCurrentDurabilityFactor())
+            {
+                await ((InventoryStorage?)player.Inventory)!.RaiseEquippedItemsChangedAsync(item, true).ConfigureAwait(false);


RepairItemAsync(player, slot) can be called for any inventory slot, not just equipped ones. For a non-equipped item this now raises EquippedItemsChanged, which runs UpdateItemsOnChangeAsync → OnAppearanceChanged and broadcasts an appearance change to all observers for what is just a backpack repair. Worth guarding on the item actually being equipped.

Also, the ((InventoryStorage?)player.Inventory)! cast (here, below, and in Player.DecreaseItemDurabilityAsync) would be nicer as a member on IInventoryStorage — the interface is what everything else consumes.

Generated by Claude Code

sven-n · 2026-09-24T17:42:19Z

+    private readonly AttributeDefinition[] _durabilityAffectedItemAttributes =
+    [
+        Stats.DefenseBase,
+        Stats.DefenseShield,
+        Stats.DefenseRatePvm,
+        Stats.MinimumPhysBaseDmgByWeapon,
+        Stats.MaximumPhysBaseDmgByWeapon,
+        Stats.StaffRise,
+        Stats.ScepterRise,
+        Stats.BookRise,
+    ];


Nit: this can be static readonly, and since it's hit with Contains for every base power-up of every item, a HashSet<AttributeDefinition> (or FrozenSet) would avoid the linear scan.

Generated by Claude Code

sven-n · 2026-09-24T17:42:23Z

+    ItemDurabilityRefactor075 = 115,
+
+    /// <summary>
+    /// The version of the <see cref="ItemDurabilityRefactorPlugIn095D"/>.


Nit: the class is ItemDurabilityRefactorPlugIn095d (lower-case d), so this cref doesn't resolve (CS1574).

Generated by Claude Code

sven-n · 2026-09-24T17:42:39Z

+                        if (attributes[Stats.IsInSafezone] < 1 || isTransformationRing || item.IsWing())
+                        {
+                            double decrementWeight = identifier switch
+                            {
+                                var _ when isTransformationRing => 11.28, // 11.28 / 564 = 0.02
+                                var itm when itm == ItemConstants.WizardsRing => 7,
+                                var itm when itm == ItemConstants.MoonstonePendant => 6.3,
+                                _ => 0.1,
+                            };
+
+                            var durationIncrease = attributes[Stats.JewelryAndWingsDurationIncrease];
+                            if (durationIncrease == 0 || isTransformationRing)
+                            {
+                                durationIncrease = 1;
+                            }
+
+                            var decrement = decrementWeight / (player.GameContext.Configuration.HitsPerOneItemDurability * durationIncrease);


Two notes here:

durationIncrease has the same divisor problem as the weapon/armor path: JewelryAndWingsDurationIncrease comes from DurabilityReduction2 as AddRaw of Formula1204 / 100 (0.12 … 0.90), so one skill point makes jewelry and wings decay up to ~8x faster. Looks like it should be 1 + attributes[...].

The condition means wings decay even inside a safezone, while jewelry doesn't. Is that deliberate (i.e. wings wear out while idling in town too)? A short comment with the source reference would help, like the ones above.

Generated by Claude Code

ze-dom · 2026-09-25T15:03:13Z

Think I've addressed everything. All set.

ze-dom added 10 commits September 14, 2026 14:45

Initial commit

0990511

Merge branch 'master' into item_durability_refactor

e7757f1

second commit

7906e25

Fixed dur threshold factors

04a0c16

Reverted some changes to decrease number of affected files (future PR)

8bce19f

Added 'f'

a167453

Nulled out item.DurabilityThresholds wherever item.Level changes

3e0d025

Added update plugins, added event ffor equipment items changed when r…

ce38bef

…epairing items

Some fixes

bde735e

Fixed filter for MG weapon

a83cf49

ze-dom commented Sep 22, 2026

View reviewed changes

Comment thread src/GameLogic/PlayerActions/Skills/PlasmaStormSkillPlugIn.cs Outdated

ze-dom Sep 22, 2026

Copy link
Copy Markdown

Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Moved to Player.cs

ze-dom commented Sep 22, 2026

View reviewed changes

Comment thread src/GameLogic/PlugIns/PeriodicTasks/DurabilityDecayPlugIn.cs

ze-dom Sep 22, 2026

Copy link
Copy Markdown

Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

zTeamS6.3, emu

ze-dom added 2 commits September 22, 2026 21:18

Merge branch 'master' into item_durability_refactor

4abdca2

Added count to 10 to plugin

57504c6

ze-dom commented Sep 22, 2026

View reviewed changes

ze-dom added 2 commits September 22, 2026 21:57

added seconds factor for xformation ring

389105e

Added destruction of xformation ring upon 0 dur

48e2389

ze-dom commented Sep 23, 2026

View reviewed changes

Added condition to exclude wings health recovery

6f20623

ze-dom commented Sep 23, 2026

View reviewed changes

ze-dom added 2 commits September 23, 2026 17:11

Removed unnecessary base attributes

fad9a66

Added conditions to raise equippedItemsHaveChanged event

3eb11cd

ze-dom marked this pull request as ready for review September 23, 2026 16:23

sven-n reviewed Sep 24, 2026

View reviewed changes

ze-dom added 3 commits September 25, 2026 12:52

Claude feedback changes

69f931b

Merge branch 'master' into item_durability_refactor

35d9bd7

Added Transient attribute

8245834

		this.AddRandomExcellentOptions(resultItem, player);

		resultItem.Durability = craftingResultItem.Durability ?? resultItem.GetMaximumDurabilityOfOnePiece();

		private static readonly byte[] AdditionalDurabilityPerLevel = { 0, 1, 2, 3, 4, 6, 8, 10, 12, 14, 17, 21, 26, 32, 39, 47 };

		private static readonly float[] DurabilityFactors = { 0.2f, 0.3f, 0.5f };

		[NotMapped]
		public double[]? DurabilityThresholds { get; set; }

Conversation

ze-dom commented Sep 16, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ze-dom Sep 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ze-dom Sep 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ze-dom Sep 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ze-dom Sep 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ze-dom Sep 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ze-dom Sep 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ze-dom Sep 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ze-dom Sep 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ze-dom Sep 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ze-dom commented Sep 16, 2026 •

edited

Loading

ze-dom Sep 22, 2026 •

edited

Loading

ze-dom Sep 22, 2026 •

edited

Loading

ze-dom Sep 23, 2026 •

edited

Loading

ze-dom Sep 23, 2026 •

edited

Loading

ze-dom Sep 23, 2026 •

edited

Loading

ze-dom Sep 23, 2026 •

edited

Loading

ze-dom Sep 23, 2026 •

edited

Loading

ze-dom Sep 23, 2026 •

edited

Loading

ze-dom Sep 23, 2026 •

edited

Loading

ze-dom Sep 23, 2026 •

edited

Loading

ze-dom Sep 25, 2026 •

edited

Loading