PR #32 follow-ups: review fixes and a zero-decision download button - #33
Merged
Merged
Conversation
The two P2s: the download page's signing notice was a constant while the signing row beside it reads per-target state, so a pre-0.7.0 feed (a rollback, or a RELEASE_REPOSITORY fork shipping unsigned builds) would have shown the two contradicting each other — the notice now branches on the same signing state. NOTICE's claim that nothing on the site references bootagent-logo.png became false when JSON-LD started naming it as the Organization logo; it now says so. The rest are statements this branch made stale in passing: the en security description promised a verification command that only renders conditionally; four comments and two docs still described the removed Gatekeeper screenshots or the pre-dsh empty planned list; llms.txt's translation list was missing /en/help/; and the en site description dropped the backup claim the Chinese one makes. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Modelled on how ccswitch.io/zh/download leads: the detected platform's file as one prominent button, with everything needed to click it — version, target, size, signing state — restated beside it, so the common case never has to parse a six-way radio group first. The picker and the per-target panels stay directly below for everyone else; the primary block follows the picker's selection, and hides for a target with no artifact rather than keep offering the previous target's file under the new target's name. Deliberately not adopted from the reference: truncated checksums (the full digest a reader can compare character-by-character is this site's claim), a brew line (no formula exists to point at), and a download button in the home hero (the home page presents one activation entry by decision, and its e2e test guards exactly that). A "past versions" line now points at GitHub Releases from the download page itself. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR #32 merged while its last two commits were still in flight, so they arrive here as a follow-up. Both were developed and gated on top of the exact tree #32's squash produced — the cherry-picks applied clean.
1. Review fixes from #32's adversarial pass (
f8fa6d7)The fresh-context review (posted on #32) found no P0/P1. This commit lands both P2s and the seven fixable P3s:
RELEASE_REPOSITORYfork shipping unsigned builds) would have rendered "signed and notarised by Apple" next to "签名状态：未签名". The notice now branches on the samesigningstate the row reads.bootagent-logo.pngdirectly, while the new JSON-LD names it as the Organization logo on every page.llms.txttranslation list missing/en/help/; en site description now carries the backup claim the Chinese one makes.2. Zero-decision download path (
1ec70fb)Modelled on ccswitch.io/zh/download's lead: one primary button above the platform picker carrying the detected target's file, restating version · target · size · signing, following the picker's selection, hiding for targets with no artifact. Plus a "past versions → GitHub Releases" line.
Deliberately not adopted from the reference: truncated checksums (the full digest is this site's claim), a brew line (no formula exists), and hero download buttons on the home page (its one-activation-entry rule is e2e-guarded by design).
Test plan
GITHUB_TOKEN: 216 passed / 18 skipped (baseline-identical), including new assertions that the primary block offers the same file as the selected panel and follows a platform switch🤖 Generated with Claude Code