Build the module on every pull request - #2
Merged
Merged
Conversation
The parent repository's api-surface.yml only runs on parent pull requests. This module lives in its own repository, so its own pull requests were never built by anything. android-sdk had the same hole: the standalone build was only exercised by the publish workflow, so it rotted unnoticed and the breakage surfaced on release day (todo/20260816.txt §8). Add a per-PR build here before the same thing happens on iOS. .gitignore also had to be adjusted: the `.*` rule excluded `.github/` wholesale, so no workflow could ever be committed here. Only modules that need no vendor SDK can run in CI — the providers need redistribution-restricted SDKs (heresdk, ios-maps-sdk) or a token (Mapbox). This one depends on MapConductorCore alone.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The parent repository's api-surface.yml only runs on parent pull requests. This
module lives in its own repository, so its own pull requests were never built by
anything.
android-sdk had the same hole: the standalone build was only exercised by the
publish workflow, so it rotted unnoticed and the breakage surfaced on release
day (todo/20260816.txt §8). Add a per-PR build here before the same thing
happens on iOS.
.gitignore also had to be adjusted: the
.*rule excluded.github/wholesale,so no workflow could ever be committed here.
Only modules that need no vendor SDK can run in CI — the providers need
redistribution-restricted SDKs (heresdk, ios-maps-sdk) or a token (Mapbox).
This one depends on MapConductorCore alone.