Publishable podspec source and 1.3.1 - #3
Merged
Merged
Conversation
`s.source = { :path => __dir__ }` points at a local directory. CocoaPods trunk
needs a source it can fetch from a public URL, so the podspec could never be
pushed — which is why nothing has ever been published (`pod trunk me` reports
no pods).
Point `s.source` at the repository with `:tag => s.version.to_s`, taken from the
`s.homepage` already declared here, and bump to 1.3.1 to match android-sdk.
Local development is unaffected: react-sdk's Podfile passes `:path`, which takes
precedence over `s.source`. Verified by rebuilding the React Native sample on a
physical iPad (0 errors) and running a map UI test against it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
s.source = { :path => __dir__ }points at a local directory. CocoaPods trunkneeds a source it can fetch from a public URL, so the podspec could never be
pushed — which is why nothing has ever been published (
pod trunk mereportsno pods).
Point
s.sourceat the repository with:tag => s.version.to_s, taken from thes.homepagealready declared here, and bump to 1.3.1 to match android-sdk.Local development is unaffected: react-sdk's Podfile passes
:path, which takesprecedence over
s.source. Verified by rebuilding the React Native sample on aphysical iPad (0 errors) and running a map UI test against it.