Fix release.yml: commit version bump only after a successful signed build - #59
Merged
Merged
Conversation
…uild Same latent bug found on the sibling HackDex-Tracker project, which hit it for real on its first release run: the workflow committed and pushed the versionName/versionCode bump and cut CHANGELOG.md straight to main *before* attempting the signed build. If that build fails (bad keystore password, expired secret, etc.), main is left permanently bumped with no GitHub Release ever published for that version, and every retry then fails immediately because [Unreleased] is already empty. This project's own releases have all succeeded so far, but the same reordering closes the latent gap: the version-bump/changelog-cut edits stay local/uncommitted through the build, and the commit+push only happens after gh release create actually succeeds. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01XHyrsY7NaqPBFy7T7fxCc5
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Su richiesta dell'utente, porto qui lo stesso fix appena applicato su
HackDex-Tracker(PR #4), dove il bug si è verificato per davvero:release.ymlfaceva commit+push del bumpversionName/versionCodee del taglioCHANGELOG.mdprima di tentare la build firmata. Se la build/firma fallisce dopo quel commit (password keystore sbagliata, secret scaduto, ecc.),mainresta bloccato con una versione "bruciata" — bump già applicato,[Unreleased]già svuotato — ma senza che sia mai stata pubblicata una vera GitHub Release, e ogni retry successivo fallisce subito perché non c'è più contenuto nuovo da tagliare.Su questo repo le release fatte finora sono sempre andate a buon fine (bug latente, non ancora esploso qui), ma la struttura è identica a quella di HackDex-Tracker quindi lo stesso rischio esiste.
Fix
Stesso riordino: bump versione/changelog restano modifiche locali non committate durante tutta la build/firma;
git commit/git pushversomainè ora l'ultimo step del workflow, eseguito solo dopo chegh release createè andato a buon fine. Aggiornata anche la documentazione (docs/implementation-decisions.md,CLAUDE.md— punto 4 della sequenza "Cutting an actual release",CHANGELOG.md).Test plan
python3 -c "import yaml; yaml.safe_load(...)".Releasereale di questo progetto.Generated by Claude Code